Remove Entrypoint inputs.root-sbd, Add inputs.spack-manifest-path Where Missing#347
Merged
CodeGat merged 6 commits intospack-v1-migrationfrom Jan 21, 2026
Merged
Conversation
CodeGat
added
type:enhancement
github-project-automation
bot
moved this to New Issues 🌅
in Spack `0.22` to `1.0` Migration
CodeGat
force-pushed
the
342-name-reserved-def-as-sbr
branch
from
009e3dc to
ad108b8
Compare
Replaced root-sbd with manifest _name reserved def Replaced pr with coalescing pr number / "issue" number
…spack-manifest-path, removed caller path for checkout
…spack-manifest-path
CodeGat
force-pushed
the
342-name-reserved-def-as-sbr
branch
from
ad108b8 to
98d4023
Compare
CodeGat
commented
Jan 21, 2026
aidanheerdegen
approved these changes
Jan 21, 2026
Member
aidanheerdegen
left a comment
aidanheerdegen
left a comment
There was a problem hiding this comment.
Awesome work. Thanks for the run-through.
github-project-automation
bot
moved this from Review 👏
to Done ✅
in Spack `0.22` to `1.0` Migration
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #342
References #326
Important
This is a major update to the infrastructure (due to the removal of an entrypoint input). However, it is being rolled into the proposed
v8changes in #326Background
While we are making major-level changes, we might as well go through the entrypoint inputs.
As we move towards the Reserved Definition
_namebeing used as the root spec, we no longer need the MDR to populate this as an entrypoint input - it creates duplication.Futhermore, some entrypoints were still requiring the MDR to populate the
PRnumber depending on if the trigger wason.pull_requestvson.issue_comment- we can infer that from the caller ourselves.Finally, some entrypoints did not have a
spack-manifest-pathinput - even if we don't intend to go past the default of./spack.yaml, it's good to have all the entrypoints in line with this.The PR
Testing
Success - see https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/21159184318/job/60850244732?pr=62
Once Merged...