Spack V1 Migration Feature: config/versions.json custom-scopes Field#335
Merged
CodeGat merged 5 commits intospack-v1-migrationfrom Jan 20, 2026
Merged
Conversation
a8c5a74 to
21d42e0
Compare
3da2716 to
a685e21
Compare
55318a5 to
868401e
Compare
6 tasks
868401e to
6c789f5
Compare
6c789f5 to
388144a
Compare
Member
Author
|
Ready for review! |
aidanheerdegen
approved these changes
Jan 20, 2026
Member
aidanheerdegen
left a comment
There was a problem hiding this comment.
Looks good! Is there some documentation updates required as well?
Member
Author
|
Yes, but that is part of the respective template PRs, like ACCESS-NRI/model-deployment-template#37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #334
Important
This is also another major change, but it is being rolled into other major changes, see #326
Background
Currently, we use a custom
spack.config.install_treeinACCESS-ESM1.[56]for UKMO-restricted content.We also use an equivalent custom scope under
spack-configscustom/cd/ukmo-restricted-scopeforbuild-cdcleanup activities.It is worth moving towards the latter so there is no custom logic in MDR manifests. See the linked issue for more context.
The PR
--config-scopes to thespack installandspack modulecommands during deployment, which are populated by theconfig/versions.jsonscustom-scopesfield.Testing
Scopeless Deployment
This is equivalent to our non-
ukmo-related models that require no special scopes - see theversions.jsonthat has nocustom-scopesfield. This succeeded: https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/21120479337/job/60732483183?pr=61#step:16:38Scoped Deployment (
ukmo-restricted-scope)This is equivalent to our
ukmo-related models that require theukmo-restricted-scope- see theversions.jsonthat has acustom-scopesfield. This succeeded, too: https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/21121351219/job/60734747451?pr=61#step:16:260