Skip to content

Spack V1 Migration Feature: config/versions.json custom-scopes Field#335

Merged
CodeGat merged 5 commits intospack-v1-migrationfrom
334-spack-v1-migration-config-removal-from-manifest
Jan 20, 2026
Merged

Spack V1 Migration Feature: config/versions.json custom-scopes Field#335
CodeGat merged 5 commits intospack-v1-migrationfrom
334-spack-v1-migration-config-removal-from-manifest

Conversation

@CodeGat
Copy link
Copy Markdown
Member

@CodeGat CodeGat commented Dec 2, 2025

References #334

Important

This is also another major change, but it is being rolled into other major changes, see #326

Background

Currently, we use a custom spack.config.install_tree in ACCESS-ESM1.[56] for UKMO-restricted content.
We also use an equivalent custom scope under spack-configs custom/cd/ukmo-restricted-scope for build-cd cleanup activities.
It is worth moving towards the latter so there is no custom logic in MDR manifests. See the linked issue for more context.

The PR

  • Add a loop of --config-scopes to the spack install and spack module commands during deployment, which are populated by the config/versions.jsons custom-scopes field.

Testing

Scopeless Deployment

This is equivalent to our non-ukmo-related models that require no special scopes - see the versions.json that has no custom-scopes field. This succeeded: https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/21120479337/job/60732483183?pr=61#step:16:38

Scoped Deployment (ukmo-restricted-scope)

This is equivalent to our ukmo-related models that require the ukmo-restricted-scope - see the versions.json that has a custom-scopes field. This succeeded, too: https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/21121351219/job/60734747451?pr=61#step:16:260

@CodeGat CodeGat added type:enhancement Improvements to existing features priority:high version:MAJOR Requires an update to Model Deployment Repositories CI for:v8 Applies to v8 labels Dec 2, 2025
@CodeGat CodeGat self-assigned this Dec 2, 2025
@CodeGat CodeGat changed the base branch from v8 to spack-v1-migration December 2, 2025 01:07
@CodeGat CodeGat force-pushed the 334-spack-v1-migration-config-removal-from-manifest branch from a8c5a74 to 21d42e0 Compare December 2, 2025 01:12
@CodeGat CodeGat moved this from New Issues 🌅 to In Progress 🏗️ in Spack `0.22` to `1.0` Migration Dec 2, 2025
@CodeGat CodeGat force-pushed the 334-spack-v1-migration-config-removal-from-manifest branch from 55318a5 to 868401e Compare December 18, 2025 22:56
@CodeGat CodeGat force-pushed the 334-spack-v1-migration-config-removal-from-manifest branch from 868401e to 6c789f5 Compare January 16, 2026 00:45
@CodeGat CodeGat force-pushed the 334-spack-v1-migration-config-removal-from-manifest branch from 6c789f5 to 388144a Compare January 16, 2026 05:10
@CodeGat CodeGat moved this from In Progress 🏗️ to Review 👏 in Spack `0.22` to `1.0` Migration Jan 18, 2026
@CodeGat CodeGat marked this pull request as ready for review January 18, 2026 22:29
@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented Jan 19, 2026

Ready for review!

Copy link
Copy Markdown
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Is there some documentation updates required as well?

@CodeGat
Copy link
Copy Markdown
Member Author

CodeGat commented Jan 20, 2026

Yes, but that is part of the respective template PRs, like ACCESS-NRI/model-deployment-template#37

@CodeGat CodeGat merged commit acea28e into spack-v1-migration Jan 20, 2026
@github-project-automation github-project-automation bot moved this from Review 👏 to Done ✅ in Spack `0.22` to `1.0` Migration Jan 20, 2026
@CodeGat CodeGat deleted the 334-spack-v1-migration-config-removal-from-manifest branch January 20, 2026 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for:v8 Applies to v8 priority:high type:enhancement Improvements to existing features version:MAJOR Requires an update to Model Deployment Repositories CI

Projects

Status: Done ✅

Development

Successfully merging this pull request may close these issues.

2 participants