Conversation
82f0685 to
0883f68
Compare
e8bdc20 to
450dd80
Compare
Also removed Release metadata output, as this info is obtained in the module
Now outputs model-name, model-deployment-repository, spack/config/packages git hash, root-spec-pkg hash
615e9e5 to
969c360
Compare
tmcadam
approved these changes
May 7, 2025
tmcadam
left a comment
There was a problem hiding this comment.
Had a detailed run of this PR with Tommy and happy with all that is in it.
This was referenced May 7, 2025
Closed
Closed
Merged
Merged
This was referenced May 7, 2025
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263
Important
Due to the addition of the GitHub Repository secret
TRACKING_SERVICES_POST_TOKENand GitHub Repository variableTRACKING_SERVICES_POST_URL, and removal of GitHub Repository secretBUILD_DB_CONNECTION_STR, this is considered a major upgrade. Once this is merged, all MDRs will need to upgrade tov5in order to use this new Release Provenance DB.Background
We are moving away from the initial release database to a database serviced by
tracking_services.This PR removes the old release database workflow, adds a new one, and gets release data into a format defined in https://github.com/ACCESS-NRI/schema/blob/main/au.org.access-nri/tracking_services/release_provenance/telemetry/1-0-0.json
The PR
scripts/release_provenance/tracking_services_data.pymodulecd.ymlin ebc595bdeploy-*workflows to get data required for above module, in 4f81cc2 and 916f0feworkflow_calls tov5, in 969c360Testing
Unit Testing
Added testing infrastructure for the
tracking_services_data.pymodule, undertests/scripts/release_provenance/test_tracking_services_data.py. To run:Workflow Testing
Workflow testing is ongoing via ACCESS-NRI/ACCESS-TEST#36, details will be added to this PR upon testing completion.
Prerelease - Manual Output Testing ✔️
Before testing the Release Workflow, I tested that the outputs given by the prerelease https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/14746333987 are in a valid format.
Tested via:
gh run download 14746333987 --repo access-nri/access-test python3 -m venv venv . venv/bin/activate pip install -r build-cd/scripts/release_provenance/requirements.txt python -m scripts.release_provenance.tracking_services_data \ --repository access-test \ --root-spec access-test \ --deployment-outputs ./deploy-outputs.Gadi \ --metadata-outputs ./deploy-metadata.Gadi \ --output ./output.jsonI then uploaded the
output.jsonto the staging area manually and verified its validity. TheACCESS-TESTmodel in the staging database can be found at https://reporting-dev.access-nri-store.cloud.edu.au/release-provenance/releases/20/.Release - Outputs Posted Via Workflow ✔️
Using a test Gadi Release GitHub Environment, I merged (after fixes, multiple) PRs that ran through the entire workflow to success. Successfully posted provenance, see https://github.com/ACCESS-NRI/ACCESS-TEST/actions/runs/14767933751/job/41463262076#step:7:15, and the model in the staging database can be found at https://reporting-dev.access-nri-store.cloud.edu.au/release-provenance/releases/21/.