Support Deployment Target Choice For Deployment Repositories#211
Conversation
CodeGat
added
type:enhancement
CodeGat
force-pushed
the
209-support-deployment-target-choice
branch
from
1125f49 to
2f52e43
Compare
jo-basevi
left a comment
jo-basevi
left a comment
There was a problem hiding this comment.
Looks great!
Feel free to ignore this but as the logic is similar in both files, it almost could be worth a reusable action with an input to pass ${{ vars.PRERELEASE_DEPLOYMENT_TARGETS }} or ${{ vars.RELEASE_DEPLOYMENT_TARGETS }}
|
Thats a good idea. Made even good-er-er by the fact that I forgot to do similar logic in |
CodeGat
dismissed
jo-basevi’s stale review
Dismissing so I don't accidentally merge - convert into action and add similar logic to ci-closed.yml
|
Thanks for your feedback @jo-basevi - I've created the action in 895fdd0 and added it to As I'd noted before, I forgot to do |
jo-basevi
left a comment
jo-basevi
left a comment
There was a problem hiding this comment.
Looks good - Nice change on merging undeploy into one workflow
2 participants
References #209
Important
This updated changes the model-deployment repositories
ci.ymlspr-closedjob to accepting aroot-sbdargument rather than amodelone. This is a major update, which will be incorporated into the overalldev-121-multi-target-workflows.Background
Instead of the deployment targets coming from
build-cdand being unchangeable from the model deployment repositories perspective, allow choice based on model deployment repository by picking deployment targets, set as repo-levelvars. Specifically, this PR addsvars.RELEASE_DEPLOYMENT_TARGETSandvars.PRERELEASE_DEPLOYMENT_TARGETSto all model deployment repositories. These MUST be set for any repositories implementing the futurev4of the infrastructure that this PR is a part of.In this PR:
vars- turned this into a custom action (get-target-matrix)ci-closed.yml, I needed to rework some of the logic. This led to a big simplification in that pipeline.Testing
The
jqsteps were tested locally on different$valid_targets, and$repo_release_targets- especially the intersection in$targets.