Prerelease Versioning Via Deployment Count#167
Merged
Conversation
CodeGat
force-pushed
the
157-spack-env-counter
branch
from
b98e14e to
00fa254
Compare
This was referenced Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
number of deployments + 1instead ofnumber of commits, which allows for rebases to model deployment repositories. This continues the convention of an ordinal number in the prerelease version, such aspr12-2denoting the second deployment of the 12th PR.NOTE: This means that failed deployments still take up a count. For example, if deployment 2 failed, but deployment 3 succeeded in the above example, only
pr12-1andpr12-3would exist on the deployment target.Important
Existing PRs that already have the existing environments counts used will not deploy successfully still
References #157
Closes #141