Skip to content

SPR modifications to support api-v2 (Spack v1.x)#332

Closed
harshula wants to merge 10 commits intomainfrom
api-v2
Closed

SPR modifications to support api-v2 (Spack v1.x)#332
harshula wants to merge 10 commits intomainfrom
api-v2

Conversation

@harshula
Copy link
Copy Markdown
Collaborator

@harshula harshula commented Oct 8, 2025

DRAFT to track changes

@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Nov 3, 2025

Hey @harshula, the error is because of the changed directory structure for spack-packages between api-v1 and api-v2. Unfortunately I can't suggest changes directly because the bits I want to change are unmodified. But:

In https://github.com/ACCESS-NRI/spack-packages/blob/cc4ec27340bc179b1efade7c74938e49ea61d5b6/.github/workflows/ci.yml#L5, you need to change that to - spack_repo/access/nri/packages/**

In https://github.com/ACCESS-NRI/spack-packages/blob/cc4ec27340bc179b1efade7c74938e49ea61d5b6/.github/workflows/ci.yml#L51, change it to path: ./spack_repo/access/nri/packages

@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Nov 4, 2025

For the next run of checks @harshula, feel free to up the max-parallel to 5...just so it goes a bit quicker! The relevant line can be found here: https://github.com/ACCESS-NRI/spack-packages/pull/332/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL134

@harshula harshula force-pushed the api-v2 branch 4 times, most recently from 2bed8ad to 78b303f Compare November 4, 2025 02:37
@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Nov 4, 2025

Just noting that I've updated the upstream image in the cluster to :rocky-v1.0-2025.11.000, which contains the [email protected] target=x86_64 compiler.

@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Nov 5, 2025

@harshula, once this run is done, feel free to up the max-parallel to 7

@harshula harshula force-pushed the api-v2 branch 3 times, most recently from 58dedf3 to f571b78 Compare December 17, 2025 00:58
@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Dec 17, 2025

@harshula 🥳

harshula and others added 10 commits February 10, 2026 10:43
* Hyphen is replaced by underscore.
* __init__.py: review feedback from Peter Scheibel.
* spack-repo-index.yaml: suggested by Tommy Gatti.
* .github/build-ci/data/standard_definitions.json:
  * Change syntax to suit toolchains
* Update spack.yaml templates to use Spack v1.x compiler toolchains syntax
* .github/workflows/ci.yml:
  * DEFAULT_SPACK_REF: 'releases/v1.1'
* Add a generic intel-oneapi-compilers test
* %[email protected] can not compile the latest version of python
  * Require python 3.11.14.
* max-parallel increased from 3 to 5.

* PR 346:
  * Update paths to `api-v2` format
  * Replace `_` from directory name with `-` for package names
  * Swap filepath and template_value so package name comes first in matrix
  * Consolidate all refs to packages path under env.PACKAGES_ROOT_DIR

Co-authored-by: Tommy Gatti <[email protected]>
infra: Update to v3, get default spack-config-ref/spack-ref from build-ci workflow, use default container-image-version
@harshula harshula marked this pull request as ready for review February 10, 2026 05:17
Copy link
Copy Markdown
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to pre-emptively approve this even though the checks haven't finished, that's how hopeful I am. Even though this branch will be the next default branch.

@harshula
Copy link
Copy Markdown
Collaborator Author

Branch main is deprecated and will be deleted in the future.

This PR does NOT need to be merged into the main branch. We will be using api-v2 branch with Spack v1.

@harshula harshula closed this Feb 11, 2026
@github-project-automation github-project-automation bot moved this from In Progress 🏗️ to Done ✅ in Spack `0.22` to `1.0` Migration Feb 11, 2026
@github-project-automation github-project-automation bot moved this from New Issues 🌅 to Done ✅ in Model Release Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✅
Status: Done ✅

Development

Successfully merging this pull request may close these issues.

2 participants