Skip to content

Next release: 2025.01.1#61

Merged
dougiesquire merged 3 commits intomainfrom
dev
Mar 11, 2025
Merged

Next release: 2025.01.1#61
dougiesquire merged 3 commits intomainfrom
dev

Conversation

@dougiesquire
Copy link
Copy Markdown
Collaborator

@dougiesquire dougiesquire commented Mar 6, 2025 •
edited by github-actions bot
Loading

A PR to assemble changes for the next release (following 2025.01.0).

🚀 The latest prerelease access-om3/pr61-5 at 8f019e1 is here: #61 (comment) 🚀

@dougiesquire dougiesquire added the next-release Changes for next release label Mar 6, 2025
This was referenced Mar 6, 2025
Closed
Closed
@dougiesquire dougiesquire changed the title Next release Next release: 2025.03.0 (tentatively) Mar 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2025

🚀 Attempted to deploy access-om3 Prerelease pr61-1 with commit 2fa3718

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-om3 model will be deployed to Gadi as:

  • 2025.01.0 as a Release (when merged).
  • pr61-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr61-1

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr61-1 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.001
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@dougiesquire dougiesquire marked this pull request as ready for review March 7, 2025 04:11
@dougiesquire dougiesquire changed the title Next release: 2025.03.0 (tentatively) Next release: 2025.03.0 Mar 7, 2025
minghangli-uni
minghangli-uni previously approved these changes Mar 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dougiesquire

@anton-seaice
Copy link
Copy Markdown
Collaborator

anton-seaice commented Mar 7, 2025

As there are no code changes - I think this can be a patch release and version 2025.1.1 ? Maybe the release team have views ?

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 7, 2025 •
edited
Loading

As there are no code changes - I think this can be a patch release and version 2025.1.1 ? Maybe the release team have views ?

I wondered about this. It does change answers and fixes (well, avoids) what we suspect is a bug. And it feels strange to me to release something in March with the version 2025.01.1. Happy to do whatever the release team recommend. @aidanheerdegen?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

🚀 Attempted to deploy access-om3 Prerelease pr61-2 with commit 2a358d4

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-om3 model will be deployed to Gadi as:

  • 2025.01.0 as a Release (when merged).
  • pr61-2 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr61-2

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr61-2 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.001
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@minghangli-uni
Copy link
Copy Markdown
Collaborator

minghangli-uni commented Mar 7, 2025

If I understand correct, a symmetry change in the MOM6 codebase could be considered a code change, as it affects the stencils and couplings with NUOPC? Given this, I may lean towards 2025.03.0.

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 7, 2025 •
edited
Loading

@CodeGat I think this is reporting wrong:

Screenshot 2025-03-07 at 4 18 16 pm

ADDED: Sorry, scratch that, it was reporting from a previous commit and I'm a dunce

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 7, 2025

🚀 Attempted to deploy access-om3 Prerelease pr61-3 with commit 3f30a98

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-om3 model will be deployed to Gadi as:

  • 2025.03.0 as a Release (when merged).
  • pr61-3 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr61-3

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr61-3 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.001
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@aidanheerdegen
Copy link
Copy Markdown
Member

aidanheerdegen commented Mar 7, 2025

As there are no code changes - I think this can be a patch release and version 2025.1.1 ? Maybe the release team have views ?

I wondered about this. It does change answers and fixes (well, avoids) what we suspect is a bug. And it feels strange to me to release something in March with the version 2025.01.1. Happy to do whatever the release team recommend. @aidanheerdegen?

It's not hard and fast, but the thinking behind this CalVer versioning was what useful information can we provide through a version string? CalVer at least has the benefit of giving some idea about the "generation" of the model and how long ago that was. And the point releases are intended to be used when the model is ostensibly unchanged but there are minor updates.

There is no right answer, but I wouldn't change the major (CalVer) part just because it seems like a long time ago. If that represents when the last major update of the model occurred so be it.

Given what you've said in the comments I'd be in favour of 2025.01.1 in this case.

@aidanheerdegen
Copy link
Copy Markdown
Member

aidanheerdegen commented Mar 7, 2025

If I understand correct, a symmetry change in the MOM6 codebase could be considered a code change, as it affects the stencils and couplings with NUOPC? Given this, I may lean towards 2025.03.0.

Ooops. Right so if you think it is major enough then use 2025.03.0. Up to you really.

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 7, 2025

Sounds like a problem for next week

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 10, 2025

@chrisb13 can you help us make a call here please?

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 11, 2025

This is holding up a few things I want to do and is an inconsequential decision, so I'm making the call to use 2025.01.1 (yes, I changed my mind over the weekend)

@dougiesquire dougiesquire changed the title Next release: 2025.03.0 Next release: 2025.01.1 Mar 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2025

🚀 Attempted to deploy access-om3 Prerelease pr61-4 with commit 8f019e1

🖥️ Gadi Deployment ❌

@dougiesquire
Copy link
Copy Markdown
Collaborator Author

dougiesquire commented Mar 11, 2025

!redeploy

@chrisb13
Copy link
Copy Markdown
Collaborator

chrisb13 commented Mar 11, 2025

so I'm making the call to use 2025.01.1 (yes, I changed my mind over the weekend)

Sounds good to me. Given the small changes, I think keeping the name similar to 2025.01.0 helps remind us that they are closely related.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 11, 2025

🚀 Attempted to deploy access-om3 Prerelease pr61-5 with commit 8f019e1

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-om3 model will be deployed to Gadi as:

  • 2025.01.1 as a Release (when merged).
  • pr61-5 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om3/pr61-5

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om3-pr61-5 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.03.001
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

minghangli-uni
minghangli-uni approved these changes Mar 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I dont have a strong preference on this. I am happy with 2025.01.1. Thanks @dougiesquire

@dougiesquire dougiesquire merged commit e5f7419 into main Mar 11, 2025
10 of 11 checks passed
@dougiesquire dougiesquire deleted the dev branch March 11, 2025 02:52
@dougiesquire dougiesquire mentioned this pull request Apr 8, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minghangli-uni minghangli-uni minghangli-uni approved these changes

@anton-seaice anton-seaice Awaiting requested review from anton-seaice

Assignees

No one assigned

Labels

next-release Changes for next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dougiesquire @anton-seaice @minghangli-uni @aidanheerdegen @chrisb13