Skip to content

Set the spack-version explicitly when @git.<gitref> is used#96

Merged
harshula merged 1 commit intomainfrom
update-specs
Feb 3, 2025
Merged

Set the spack-version explicitly when @git.<gitref> is used#96
harshula merged 1 commit intomainfrom
update-specs

Conversation

@harshula
Copy link
Copy Markdown
Collaborator

@harshula harshula commented Jan 31, 2025 •
edited by github-actions bot
Loading

  • Spack upstream is planning to insert a spack-version when one is not explicitly provided.
  • The error we saw when using spack config change can be avoided when a spack-version is explicitly provided.
  • This change depends on the latest spack-packages.

🚀 The latest prerelease access-om2/pr96-1 at d18ea21 is here: #96 (comment) 🚀

@harshula harshula requested a review from CodeGat January 31, 2025 04:14
@harshula harshula self-assigned this Jan 31, 2025
@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Jan 31, 2025

Testing

ACCESS-NRI/access-spack-packages#185

@harshula harshula mentioned this pull request Jan 31, 2025
Closed
@harshula
Copy link
Copy Markdown
Collaborator Author

harshula commented Feb 3, 2025

Hi @CodeGat , Will you be able to expand the CI regexp today?

@CodeGat
Copy link
Copy Markdown
Member

CodeGat commented Feb 3, 2025 •
edited
Loading

Updating the schema is fine, the issue is that it would require changes to the infrastructure as well. We have a big infrastructure update coming soon, and I could add it to that.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

The model version in the spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

🚀 Deploying access-om2 2024.03.1 as prerelease pr96-1 with commit d18ea21

Details and usage instructions

This access-om2 model will be deployed as:

  • 2024.03.1 as a Release (when merged).
  • pr96-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr96-1

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2-pr96-1 environment.

🛠️ Using: spack 0.22, spack-packages 2025.01.1, spack-config 2025.01.1

Details

It will be deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.01.1
  • access-nri/spack-config version 2025.01.1

If this is not what was expected, commit changes to config/versions.json.

CodeGat
CodeGat requested changes Feb 3, 2025
View reviewed changes
@harshula
[skip ci] Set the spack-version explicitly when @git.<gitref> is used
c21f16a 
* Spack upstream is planning to insert a spack-version when one is
  not explicitly provided.
* The error we saw when using `spack config change` can be avoided
  when a spack-version is explicitly provided.
* The latest spack-packages repository contains changes that this
  change requires.
@harshula harshula requested a review from CodeGat February 3, 2025 04:35
@harshula harshula merged commit 9a3a67f into main Feb 3, 2025
@harshula harshula deleted the update-specs branch February 3, 2025 06:01
This was referenced Feb 20, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeGat CodeGat CodeGat approved these changes

Assignees

@harshula harshula

Labels

None yet

Projects

ACCESS-OM2 Spack
Status: Done
Model Release
Status: Done ✅

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshula @CodeGat