Merged
Conversation
Apply suggestions from code review Co-authored-by: Tommy Gatti <[email protected]> Co-authored-by: Andrew Kiss <[email protected]> Co-authored-by: Tommy Gatti <[email protected]> Co-authored-by: Dougie Squire <[email protected]> Co-authored-by: Claire Carouge <[email protected]>
Closed
Member
Author
|
This is a branch from #63, with all the commits squashed and single second commit to remove the two problematic examples, to get something useful published and work on the other examples in other PRs. |
This was referenced May 23, 2024
Collaborator
|
I tested the instructions and they worked as documented. |
aidanheerdegen
force-pushed
the
issue58-initial
branch
from
5f4b36c to
f012b5d
Compare
harshula
approved these changes
May 31, 2024
Collaborator
harshula
left a comment
harshula
left a comment
There was a problem hiding this comment.
Looks good, well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add initial version of developer docs showing how to use a spack model environment to develop the code of a single component.
Addresses #58