'Rolling Tag' logic for pre/release builds#47
Merged
Conversation
Member
Author
|
Prerelease looks like this: gitGraph
commit id: "2024.01.1" type: HIGHLIGHT tag: "2024.01.01"
branch pre-2024.01.2
checkout pre-2024.01.2
commit id: "access-om2_2024.01.2-1"
commit id: "access-om2_2024.01.2-2"
commit id: "access-om2_2024.01.2-3"
checkout main
merge pre-2024.01.2 id: "2024.01.2" type: HIGHLIGHT tag: "2024.01.2"
|
aidanheerdegen
approved these changes
Feb 26, 2024
Member
aidanheerdegen
left a comment
aidanheerdegen
left a comment
There was a problem hiding this comment.
Looks good to merge and test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
* cd.yml: Moved tagging logic to before deployment
This fixes up the issue of the
spack.yamlfile (specifically, thespack.specs[email protected]) looking to clone the tag that doesn't exist (yet). We add a rolling tag for the prerelease branch so the build can progress, and then when it is merged, place the tag in it's rightful position on themainbranch.This 'rolling tag' logic is noted here:
And then when the next commit comes along:
and then when merged: