Conversation
harshula
force-pushed
the
30-require-parallelio-2.5.2
branch
from
228f845 to
2ae4924
Compare
CodeGat
approved these changes
Jan 23, 2024
Member
CodeGat
left a comment
CodeGat
left a comment
There was a problem hiding this comment.
Looks good to me.
Although not relevant for this particular deployment, note the config/version.json file. It contains the versions of spack-packages and spack-config that will be used to deploy access-om2. Right now they are the latest, but in future this will change.
Member
|
Something also worth noting is that I had to explicitly comment about the |
Collaborator
Author
|
The following has to be done to deploy these changes: #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #30