Conversation
CodeGat
force-pushed
the
26-modulefile-additions
branch
from
42c4c76 to
b883aa6
Compare
CodeGat
force-pushed
the
26-modulefile-additions
branch
from
18fbc93 to
11fb59f
Compare
harshula
previously approved these changes
Dec 18, 2023
Collaborator
harshula
left a comment
harshula
left a comment
There was a problem hiding this comment.
I approve the changes to spack.yaml. Hi @jo-basevi , Can you please review the rest of the changes?
…s on versions.json changed
jo-basevi
approved these changes
Dec 19, 2023
Contributor
jo-basevi
left a comment
jo-basevi
left a comment
There was a problem hiding this comment.
Changes look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR:
spack.yamlupdated to include modulefile name declarationpull_requestthat checks if thespack.yamlis validCloses #26