Skip to content

Set the spack-version explicitly when @git.<gitref> is used for specs#107

Merged
harshula merged 1 commit intomainfrom
add-spack-version-to-specs
May 19, 2025
Merged

Set the spack-version explicitly when @git.<gitref> is used for specs#107
harshula merged 1 commit intomainfrom
add-spack-version-to-specs

Conversation

@harshula
Copy link
Copy Markdown
Collaborator

@harshula harshula commented May 19, 2025 •
edited by github-actions bot
Loading

  • Spack upstream is planning to insert a spack-version when one is not explicitly provided.
  • The latest spack-packages repository contains changes that this change requires.

🚀 The latest prerelease access-om2/pr107-2 at f6af9c6 is here: #107 (comment) 🚀

@harshula
Set the spack-version explicitly when @git.<gitref> is used for specs
f6af9c6 
* Spack upstream is planning to insert a spack-version when one is
  not explicitly provided.
* The error we saw when using `spack config change` can be avoided
  when a spack-version is explicitly provided.
* The latest spack-packages repository contains changes that this
  change requires.
@harshula harshula requested a review from CodeGat May 19, 2025 01:19
@harshula harshula self-assigned this May 19, 2025
@harshula harshula temporarily deployed to Gadi Prerelease May 19, 2025 01:19 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2025

🚀 Attempted to deploy access-om2 Prerelease pr107-1 with commit f6af9c6

🖥️ Gadi Deployment ✔️

Usage Instructions

This access-om2 model will be deployed to Gadi as:

  • 2024.03.0 as a Release (when merged).
  • pr107-1 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules
module load access-om2/pr107-1

When using the above modules, the binaries shall be on your $PATH.

For advanced users, this Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.22/spack in the access-om2-pr107-1 environment.

Configuration Information

This Prerelease is deployed using:

  • access-nri/spack on branch 0.22
  • access-nri/spack-packages version 2025.01.1
  • access-nri/spack-config version 2025.02.2

If the above was not what was expected, commit changes to config/versions.json in this PR.

@harshula harshula marked this pull request as ready for review May 19, 2025 01:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2025

The model version in the ./spack.yaml has not been updated.
Either update it manually, or comment the following to have it updated and committed automatically:

  • !bump major for feature releases
  • !bump minor for bugfixes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 19, 2025

🚀 Attempted to deploy access-om2 Prerelease pr107-2 with commit f6af9c6

🖥️ Gadi Deployment ❌

CodeGat
CodeGat approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@CodeGat CodeGat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the [skip ci]!

@harshula harshula merged commit d0b8024 into main May 19, 2025
19 of 20 checks passed
@harshula harshula temporarily deployed to Gadi Prerelease May 19, 2025 01:39 — with GitHub Actions Inactive
@harshula harshula deleted the add-spack-version-to-specs branch May 19, 2025 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeGat CodeGat CodeGat approved these changes

Assignees

@harshula harshula

Labels

None yet

Projects

ACCESS-OM2 Spack
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harshula @CodeGat