Skip to content

Remove dependencies#96

Merged
AArnott merged 1 commit into
AArnott:masterfrom
bdovaz:remove-dependencies
Dec 24, 2021
Merged

Remove dependencies#96
AArnott merged 1 commit into
AArnott:masterfrom
bdovaz:remove-dependencies

Conversation

@bdovaz

@bdovaz bdovaz commented Dec 24, 2021

Copy link
Copy Markdown
Contributor

Remove unnecessary System.Runtime.InteropServices dependency.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #96 (6141a54) into master (95eff87) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   91.43%   91.43%           
=======================================
  Files           9        9           
  Lines         292      292           
=======================================
  Hits          267      267           
  Misses         25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95eff87...6141a54. Read the comment docs.

@AArnott AArnott merged commit 4bcbb5d into AArnott:master Dec 24, 2021
@bdovaz bdovaz deleted the remove-dependencies branch December 24, 2021 16:54
@bdovaz

bdovaz commented Dec 24, 2021

Copy link
Copy Markdown
Contributor Author

@AArnott can you release a new NuGet package version without this dependency? Thanks.

@AArnott

AArnott commented Dec 24, 2021

Copy link
Copy Markdown
Owner

How is this blocking you?

@bdovaz

bdovaz commented Dec 24, 2021

Copy link
Copy Markdown
Contributor Author

Yes because we use it with Unity and it only supports .NET Standard 2.0 / 2.1 packages.

We use it with:

https://github.com/xoofx/UnityNuGet

@AArnott

AArnott commented Dec 25, 2021

Copy link
Copy Markdown
Owner

Ok. 2.6.13-beta is on its way to nuget.org now.

@bdovaz

bdovaz commented Dec 25, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, but that UnityNuGet library only works with stable versions...

@AArnott

AArnott commented Dec 25, 2021

Copy link
Copy Markdown
Owner

Then you'll need to send a PR to our latest stable branch instead of our main development branch.

@bdovaz

bdovaz commented Dec 28, 2021

Copy link
Copy Markdown
Contributor Author

@AArnott

AArnott commented Dec 28, 2021

Copy link
Copy Markdown
Owner

Oh, gosh. I guess in this repo I don't have a stable branch for v2.5. Let me get back to you on that.

@AArnott

AArnott commented Dec 29, 2021

Copy link
Copy Markdown
Owner

Ok. I've pushed a v2.5 branch and cherry-picked your change to it. We'll get a stable 2.5 release out to nuget.org today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants