Adds Requires.ValidElements#44
Merged
Merged
Conversation
…eline build treats this as an error while it was just a warning locally.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 88.21% 88.88% +0.67%
==========================================
Files 9 9
Lines 263 279 +16
==========================================
+ Hits 232 248 +16
Misses 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AArnott
requested changes
Sep 26, 2020
AArnott
left a comment
AArnott
left a comment
Owner
There was a problem hiding this comment.
Looks good. Thanks for contributing. A few comments.
Removed using directive grouping blank lines and set an .editorconfig value to control it. Added additional tests to validate null value parameter, a predicate that throws an exception, and that the message formatting is correct. Also changed the Assert.Throws to use an overload that verifies the exception parameter name.
…ake a StringCompare parameter.
AArnott
requested changes
Sep 27, 2020
AArnott
added a commit
that referenced
this pull request
May 2, 2023
Add machine-wide .NET install support off Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #41, adds
Requires.ValidElementsmethod and associated unit tests.