Settings → Block save after failed connection test - #162

Resolves #157

Problem

• A dirty draft could still be saved while a connection test was running or after it had failed
• Disabling only the button would not protect against a queued click reaching the persistence method
• An older in-flight result could overwrite the unknown state of a draft edited while that test was running

Changes

• Define one save-eligibility rule: the draft must be dirty and its connection state must be unknown or ok
• Apply that rule to both the Save button and the persistence boundary
• Test a snapshot of the draft and discard results whose generation or settings no longer match
• Add table-driven and effect-level coverage for all four states, queued saves, and edit-during-flight races

Validation

• npm run lint
• npm run build
• npm test (208 passed)
• npm run test:integration (25 passed)
• npm run check-versions
• npm run audit (0 vulnerabilities)
• Secretlint on all changed files
• git diff --check

Greptile Summary

Adds a unified save-eligibility rule and stale connection-result protection.

• Blocks settings persistence while a connection test is running or after it fails.
• Snapshots tested settings and discards results that no longer match the current generation or draft.
• Adds unit and effect-level coverage for save states, queued saves, and edit-during-test behavior.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified in the changed behavior.

The Save button and persistence boundary now enforce the same eligibility rule, while connection tests use immutable settings snapshots and generation checks before updating state.

Important Files Changed

_{Reviews (1): Last reviewed commit: "Settings → Block save after failed conne..." | Re-trigger Greptile}