Skip to content

Embed Qt base translations in the executable#4973

Merged
OBattler merged 1 commit into
86Box:masterfrom
lemondrops:qt_translations
Nov 17, 2024
Merged

Embed Qt base translations in the executable#4973
OBattler merged 1 commit into
86Box:masterfrom
lemondrops:qt_translations

Conversation

@OBattler

Copy link
Copy Markdown
Member

Fixes standard messagebox buttons not being translated

Summary

Briefly describe what you are submitting.

Checklist

References

Provide links to datasheets or other documentation that helped you implement this pull request.

Fixes standard messagebox buttons not being translated
@OBattler
OBattler merged commit ea870c6 into 86Box:master Nov 17, 2024
@lemondrops

Copy link
Copy Markdown
Contributor

Since the PR was created a little prematurely, here's the original description:

Fixes standard message box buttons not being translated.

Yes, this is technically a hack, but it's consistent with what we do for translations for 86Box itself, while allowing the executable to not depend on external translation files (while they can be bundled on macOS, on Windows they may not be present on runtime and bundling them is undesirable anyway).

@lemondrops
lemondrops deleted the qt_translations branch November 17, 2024 23:31
@lemondrops lemondrops mentioned this pull request Nov 21, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants