Skip to content

Modem fixes#4321

Merged
OBattler merged 3 commits into
86Box:masterfrom
lemondrops:modem
Apr 1, 2024
Merged

Modem fixes#4321
OBattler merged 3 commits into
86Box:masterfrom
lemondrops:modem

Conversation

@lemondrops

Copy link
Copy Markdown
Contributor

Summary

  • Increase phone book size to 200 entries from 20, while decreasing the entry size from 1023 to 127 (anything longer wouldn't work anyway)
  • Make certain string operations, including phonebook parsing, safer
  • Fix escape sequence guard timer counter never resetting, effectively making the guard timer non-functional
  • Stop command line processing after dialing; dialed number no longer gets interpreted as a command, affected primarily hostnames

Checklist

  • Closes #xxx
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set

References

N/A

Also make some string operations (such as phonebook file parsing) safer
Escape sequence guard timer now actually works
"Phone numbers" with letters in them, such as hostnames, are no longer
interpreted as commands
@OBattler
OBattler merged commit 9e2b68e into 86Box:master Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants