Fix EGA fine scrolling in text modes#4016
Merged
Merged
Conversation
By the way, text mode scrolling at least seems to be correct now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the fine scroll in the EGA text modes, including 8-dot and 9-dot modes, also providing a fallback for the "shift left by 1" effect in lieu of a correct implementation of the character skew counter.
This also does some changes to the unit tester - firstly, the debug log is a lot more useful, and secondly, it's now compatible with EGA double-scanned rendering (yep, that was a bug).
Checklist
References
IBM EGA reference; vgadoc; remembering something about various SVGA datasheets explaining the horizontal panning pretty much identically to each other; testing on my S3 Trio64V2/DX for feasible behaviour.