Merge Version/4.1 into master since we have decided to just go straight for 4.1#3823
Merged
Conversation
…box into opl4-daughterboard
Port DECchip 21143 "Tulip" NIC emulation from QEMU
net_tulip.c: Copyright header
net_eeprom_nmc93cxx.c: Proper logging
Port Realtek RTL8139C+ emulation from QEMU
# Conflicts: # CMakeLists.txt # debian/changelog # src/include_make/86box/version.h # src/unix/assets/86Box.spec # src/unix/assets/net.86box.86Box.metainfo.xml # vcpkg.json
add machine Hyundai Super 286C
Report correct cache info in CPUID on P6-family CPUs
Misc 4.1 updates
[v4.1] Further adjustment to the CPUID cache stuff
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* Determine the number of voices and voice parameters */ | ||
| const YRW801_REGION_DATA *region = region_ptr[midi_channel->instrument & 0x7F].regions; | ||
|
|
||
| while (i < region_ptr[midi_channel->instrument & 0x7F].count) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly describe what you are submitting.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.