add cpl_override in pmodeiret() when cpu_state.flags has NT_FLAG#3811
Merged
Conversation
…ause the flag is reset by the function
Contributor
Author
|
With the second commit I added to this PR, this OS now boots graphically for all the cards I've tested (and they all failed to detect and run before this patch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've been hit by #1951 myself, and debugging the issue led me to guess cpl_override should be set for this read. With this patch, the warnings disappear, but OpenServer still doesn't go graphical unless a very small subset of video cards has been selected.
Checklist
References
Debugging the same CPU state in QEMU helped me verify the expected value for the
segassignment.