Add OPL4-ML daughterboard emulation#2899
Merged
Merged
Conversation
…box into opl4-daughterboard
Cacodemon345
marked this pull request as draft
November 29, 2022 20:23
Contributor
Author
|
Marked as draft to investigate note on issues. |
Cacodemon345
marked this pull request as ready for review
February 3, 2023 11:11
Cacodemon345
marked this pull request as draft
February 3, 2023 11:11
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* Determine the number of voices and voice parameters */ | ||
| const YRW801_REGION_DATA *region = region_ptr[midi_channel->instrument & 0x7F].regions; | ||
|
|
||
| while (i < region_ptr[midi_channel->instrument & 0x7F].count) { |
Check failure
Code scanning / CodeQL
Comparison of narrow type with wide type in loop condition
OBattler
marked this pull request as ready for review
August 8, 2023 22:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add OPL4-ML daughterboard emulation
Checklist
References
None.