Display acount status in the member drawer and profile card#98
Conversation
| </Text> | ||
| {presence?.status && ( | ||
| /* The Color value should be edited to the theme specific disabled text color */ | ||
| <Text size="T300" truncate style={{ color: '#888888', fontFamily: font }}> |
There was a problem hiding this comment.
Can you remove the color tag here and instead use opacity so we have general theme support?
Something like: style={{ opacity: config.opacity.P300, fontFamily: font }}
There was a problem hiding this comment.
I have updated it but in that way i think it looks very white in the default theme, i was wondering if there is a more faded option for it, so it doesn't look like it is completely its own thing iykwim
| {presence?.status?.length && ( | ||
| <div className={css.UserHeroStatusContainer}> | ||
| <Tooltip style={{ maxWidth: '90%', justifySelf: 'left' }}> | ||
| <Text size="T200"> {presence.status} </Text> |
There was a problem hiding this comment.
Does this have a max height or is there any limit for statuses? I'm wondering if long statuses might end up covering the message button.
There was a problem hiding this comment.
i am genuinely not sure how long a status_msg can be, cant find it in the spec either, commet lets you set seemingly infinitely long statuses (tho it only displays a few dozen characters), so i have made it so it has 2 modes, a collapsed mode where it doesnt cover the message button, an expanded one that does, and within the expanded one just if someone sets a stupidly long message it can scroll, and i think this is the best way around forcing a limit.
but on that note do you know any way to make it look better and more clear it is meant to be clickable?
(default/collapsed)
(expanded)
(and you can srcroll it if your friend wants to troll you with statuses or w/e)
There was a problem hiding this comment.
Maybe add a little arrow icon, like the one at the + 1 more info? Would cut into the text space a little though. Not sure tbh.
There was a problem hiding this comment.
i think it actually works well
(and only shows up if the string is >70char which is a reasonable minimum and how much text normally fits in the string, to avoid it showing up unnecessarily)
so i think this is good now
…atus sizes and the message button
2 participants
Description
This pull request makes it so that within the hero (profile card) and the member drawer you are able to see the presence (online, busy, unavailable), and the status message (a custom message) of a person.
This is how it would display using this code:
This pr is based on a (1 day) old version of sable
Type of change
Checklist: