Repository navigation
Error: original.line and original.column are not numbers when a mapping entry only contains a single field. #18
Description
Hi!
I am a contributor to postcss and an issue was reported there that I think can only be solved here: postcss/postcss#1914
Reproduction :
/* -*- Mode: js; js-indent-level: 2; -*- */
var util = require("./util");
var SourceMapGenerator = require('../lib/source-map-generator').SourceMapGenerator;
var SourceMapConsumer = require('../lib/source-map-consumer').SourceMapConsumer;
exports['test .fromSourceMap with only a single field in the last mapping entry'] = function (assert) {
var map = SourceMapGenerator.fromSourceMap(
new SourceMapConsumer(`{
"version": 3,
"file": "swagger-ui.css",
"mappings": "AAAA,iBAWE,uBAFA,sBACA,kBAEA,oCAVA,eACA,gBAEA,iBAEA,kBAKA,CAEA,wBAEE,eACA,iB",
"sources": [
"webpack://swagger-ui/./src/style/_buttons.scss"
],
"sourcesContent": [
".btn\\n{\\n font-size: 14px;\\n font-weight: bold;\\n\\n padding: 5px 23px;\\n\\n transition: all .3s;\\n\\n border: 2px solid $btn-border-color;\\n border-radius: 4px;\\n background: transparent;\\n box-shadow: 0 1px 2px rgba($btn-box-shadow-color,.1);\\n\\n &.btn-sm\\n {\\n font-size: 12px;\\n padding: 4px 23px;\\n }\\n}\\n"
],
"names": [],
"sourceRoot": ""
}`));
util.assertEqualMaps(assert, map.toJSON());
};As far as I can tell it is allowed to have fewer fields in mapping segments.
https://sourcemaps.info/spec.html#h.lmz475t4mvbx
I created the sourcemap by cloning https://github.com/swagger-api/swagger-ui and removing most of the CSS content to create a small output that was easier to read.
Any sourcemap produced by the setup in that project gives an error in source-map-js.
It is perfectly possible that the issue is with how the sourcemap is generated and not with how it is read.
Reacted by silverwind and sandrinejoy
Activity
romainmenke commentedon Jan 25, 2024
Related issue in original repo : mozilla#385
ai commentedon Jan 26, 2024
Stacktrace of the error:
7rulnik commentedon Mar 17, 2024
Hey guys! We discussed it a bit in private with @ai and @alexander-akait
Alexander said that it's a known bug but he didn't have time to solve it because of private business in real life.
Andrey suggests skipping broken source maps. I am fine with this suggestion but the real problem is that nobody of us are familiar with source code and how it actually works. I will try to look deeper into the code but can't promise anything.
ai commentedon Mar 17, 2024
Just not that I suggest skipping broken mapping (pos 1 > pos 2), not entire source map 😅
romainmenke commentedon Mar 17, 2024
Thank you for the update @7rulnik
🤔 Should we then maybe consider moving away from
source-map-jsfor PostCSS?If I understand it correctly
source-map-jsis a rescue project forsource-mapbecause it radically changed direction and became a rust project.Finding a different package for source maps might be a better long term solution?
7rulnik commentedon Mar 17, 2024
@romainmenke in my opinion — yes
There are different implementations tc39/ecma426#47
But let's keep this issue related only to source-map-js
ai commentedon Mar 17, 2024
@romainmenke can you find a good alternative with sync API?
ai commentedon Mar 17, 2024
SourceMapConsumeris part of PostCSS public API. I can’t change the implementation.7rulnik commentedon Mar 17, 2024
https://github.com/7rulnik/source-map-js/releases/tag/v1.1.0
Huge thanks @ai!
Closing this for now.
romainmenke commentedon Mar 17, 2024
Thank you @ai, @7rulnik 🙇