Repository navigation
Restore stencil buffer for the shared 3D renderer - #9253
Merged
Merged
Conversation
Bouh
approved these changes
Oct 19, 2026
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9252.
Request a stencil buffer when creating the Three.js renderer shared with PixiJS. Three.js now defaults
stenciltofalse, so stencil-tested materials can draw outside their masks.Adds real WebGL browser regressions with antialiasing disabled and with MSAA: verify the shared context, then render a half-screen stencil mask and check both masked and unmasked pixels. Turning off stencil testing also verifies that the previously masked pixel can be drawn.
Validation from the repository root (Linux, Node 24.16.0, Chromium 149 / SwiftShader):
1,405 tests pass; 29 are skipped. All four new regression cases fail on the unmodified production code and pass with the fix. Chrome uses
--disable-dev-shm-usagein Docker. Native desktop/mobile applications were not run.Related constructor work: #7400 (PixiJS 8) and #9087 (rendering resolution). This patch adds only the stencil option to the current renderer.