revert: remove unused code and fix misleading parameter naming

404tk · 404tk · commit 6de51c64b2e6 · 2026-01-07T22:20:20.000+08:00
diff --git a/pkg/providers/alibaba/alibaba.go b/pkg/providers/alibaba/alibaba.go
@@ -171,7 +171,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	}
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {
+func (p *Provider) EventDump(action, args string) {
 	d := _sas.Driver{Cred: p.cred}
 	switch action {
 	case "dump":
@@ -192,7 +192,7 @@ func (p *Provider) EventDump(action, sourceIP string) {
 			logger.Info(msg)
 		}
 	case "whitelist":
-		d.HandleEvents(sourceIP) // sourceIP here means SecurityEventIds
+		d.HandleEvents(args) // args means SecurityEventIds
 	default:
 		logger.Error("Please set metadata like \"dump all\"")
 	}
diff --git a/pkg/providers/aws/aws.go b/pkg/providers/aws/aws.go
@@ -151,7 +151,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	}
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/providers/azure/azure.go b/pkg/providers/azure/azure.go
@@ -112,7 +112,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	logger.Error("Not supported yet.")
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/providers/gcp/gcp.go b/pkg/providers/gcp/gcp.go
@@ -96,7 +96,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	logger.Error("Not supported yet.")
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/providers/huawei/huawei.go b/pkg/providers/huawei/huawei.go
@@ -153,7 +153,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	logger.Error("Not supported yet.")
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/providers/jdcloud/jdcloud.go b/pkg/providers/jdcloud/jdcloud.go
@@ -86,7 +86,7 @@ func (p *Provider) UserManagement(action, username, password string) {}
 
 func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {}
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/providers/tencent/tencent.go b/pkg/providers/tencent/tencent.go
@@ -145,7 +145,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {
 	logger.Info("Recommended use https://cosbrowser.cloud.tencent.com/web")
 }
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {
 	var region, ostype string
diff --git a/pkg/providers/volcengine/volcengine.go b/pkg/providers/volcengine/volcengine.go
@@ -108,7 +108,7 @@ func (p *Provider) UserManagement(action, username, password string) {}
 
 func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {}
 
-func (p *Provider) EventDump(action, sourceIP string) {}
+func (p *Provider) EventDump(action, args string) {}
 
 func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}
 
diff --git a/pkg/schema/errors.go b/pkg/schema/errors.go
diff --git a/pkg/schema/schema.go b/pkg/schema/schema.go
@@ -16,7 +16,7 @@ type Provider interface {
 	Resources(ctx context.Context) (Resources, error)
 	UserManagement(action, username, password string)
 	BucketDump(ctx context.Context, action, bucketName string)
-	EventDump(action, sourceIP string)
+	EventDump(action, args string)
 	ExecuteCloudVMCommand(instanceID, cmd string)
 	DBManagement(action, instanceID string)
 }
diff --git a/runner/banner.go b/runner/banner.go
@@ -12,7 +12,7 @@ const banner = `
 `
 
 // Version is the current version of cloudtoolkit
-const Version = `0.1.6`
+const Version = `0.1.7`
 
 // showBanner is used to show the banner to the user
 func ShowBanner() {

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`171`	`171`	`}`
`172`	`172`	`}`
`173`	`173`
`174`		`-func (p *Provider) EventDump(action, sourceIP string) {`
	`174`	`+func (p *Provider) EventDump(action, args string) {`
`175`	`175`	`d := _sas.Driver{Cred: p.cred}`
`176`	`176`	`switch action {`
`177`	`177`	`case "dump":`
`@@ -192,7 +192,7 @@ func (p *Provider) EventDump(action, sourceIP string) {`
`192`	`192`	`logger.Info(msg)`
`193`	`193`	`}`
`194`	`194`	`case "whitelist":`
`195`		`- d.HandleEvents(sourceIP) // sourceIP here means SecurityEventIds`
	`195`	`+ d.HandleEvents(args) // args means SecurityEventIds`
`196`	`196`	`default:`
`197`	`197`	`logger.Error("Please set metadata like \"dump all\"")`
`198`	`198`	`}`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`
`154`		`-func (p *Provider) EventDump(action, sourceIP string) {}`
	`154`	`+func (p *Provider) EventDump(action, args string) {}`
`155`	`155`
`156`	`156`	`func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}`
`157`	`157`
Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`112`	`112`	`logger.Error("Not supported yet.")`
`113`	`113`	`}`
`114`	`114`
`115`		`-func (p *Provider) EventDump(action, sourceIP string) {}`
	`115`	`+func (p *Provider) EventDump(action, args string) {}`
`116`	`116`
`117`	`117`	`func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}`
`118`	`118`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`96`	`96`	`logger.Error("Not supported yet.")`
`97`	`97`	`}`
`98`	`98`
`99`		`-func (p *Provider) EventDump(action, sourceIP string) {}`
	`99`	`+func (p *Provider) EventDump(action, args string) {}`
`100`	`100`
`101`	`101`	`func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}`
`102`	`102`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`153`	`153`	`logger.Error("Not supported yet.")`
`154`	`154`	`}`
`155`	`155`
`156`		`-func (p *Provider) EventDump(action, sourceIP string) {}`
	`156`	`+func (p *Provider) EventDump(action, args string) {}`
`157`	`157`
`158`	`158`	`func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {}`
`159`	`159`
Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func (p *Provider) BucketDump(ctx context.Context, action, bucketName string) {`
`145`	`145`	`logger.Info("Recommended use https://cosbrowser.cloud.tencent.com/web")`
`146`	`146`	`}`
`147`	`147`
`148`		`-func (p *Provider) EventDump(action, sourceIP string) {}`
	`148`	`+func (p *Provider) EventDump(action, args string) {}`
`149`	`149`
`150`	`150`	`func (p *Provider) ExecuteCloudVMCommand(instanceID, cmd string) {`
`151`	`151`	`var region, ostype string`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ type Provider interface {`
`16`	`16`	`Resources(ctx context.Context) (Resources, error)`
`17`	`17`	`UserManagement(action, username, password string)`
`18`	`18`	`BucketDump(ctx context.Context, action, bucketName string)`
`19`		`- EventDump(action, sourceIP string)`
	`19`	`+ EventDump(action, args string)`
`20`	`20`	`ExecuteCloudVMCommand(instanceID, cmd string)`
`21`	`21`	`DBManagement(action, instanceID string)`
`22`	`22`	`}`