Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: 3scale/APIcast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.15.0
Choose a base ref
...
head repository: 3scale/APIcast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.15.1
Choose a head ref
  • 11 commits
  • 10 files changed
  • 2 contributors

Commits on Apr 19, 2024

  1. Configuration menu
    Copy the full SHA
    9f18cdf View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Merge pull request #1459 from tkan145/backport-THREESCALE-10934-batch…

    …er-policy-not-accept-special-chars
    
    Backport 2.15 THREESCALE-10934 Batcher policy does not accept the same chars specified in Porta regex for app_id, app_key & user_key
    tkan145 authored Apr 23, 2024
    Configuration menu
    Copy the full SHA
    17aa557 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Prevent APIcast fallback to global proxy settings for direct connection

    With the newer version of lua-resty-http (0.7.1), if a proxy options
    is not provided when calling the connect() method, it will fall back to
    using the global proxy settings set by the "set_proxy_option" function
    (has no effect in previous versions of the library). This then causes
    unexpected behavior where the direct connection will now go through
    the proxy server.
    
    This PR explicitly sets the proxy options to an empty table to bypass
    global proxy settings when connecting directly.
    tkan145 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    573a070 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1480 from tkan145/backport-THREESCALE-11128

    [THREESCALE 11128] Prevent APIcast fallback to global proxy settings for direct connection
    tkan145 authored Jun 27, 2024
    Configuration menu
    Copy the full SHA
    cefafe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Update busted

    CI failed to download dependencies from
    http://dkolf.de/src/dkjson-lua.fsl/tarball/dkjson-2.6.tar.gz?uuid=release_2_6.
    
    The endpoint for version 2.6 seems to no longer exist so upgrading busted
    to use newer dkjson version
    tkan145 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    89899de View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1484 from tkan145/fix-ci

    Update busted
    tkan145 authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8c94b99 View commit details
    Browse the repository at this point in the history
  3. Ensure we don't schedule reloading configuration when reloading is di…

    …sabled
    
    Details of the issue as well as local reproducers are documented in #1467.
    
    This change ensures that when `boot.init_worker` checks to see whether or not
    the configuration needs to be reloaded, it also checks to confirm that the `boot.ttl()`
    value set from `APICAST_CONFIGURATION_CACHE` is a positive number, in order to avoid
    an immediate and infinite recursive loop of refreshing the configuration.
    
    This should still preserve the initial fix [1] where this regression appears to
    have been introduced, as we should never schedule reloading with the configuration settings of:
    
    ```
    APICAST_CONFIGURATION_LOADER: boot
    APICAST_CONFIGURATION_CACHE: -1
    ```
    
    We should also never have a situation where we'd need to account for `interval = 0`
    since we fail out in `boot.init` in that case [2].
    
    Tested locally as documented in the issue, however based on the comment in the initial
    fix PR, I've not added any tests in code. Happy to do so if there's now a good way
    to accomplish that!
    
    [1] #1399
    [2] https://github.com/3scale/APIcast/blob/7e7eaf6f1d584c78d999c0d09f5b65203161c402/gateway/src/apicast/configuration_loader.lua#L146-L149
    coderbydesign authored and tkan145 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    fd6b277 View commit details
    Browse the repository at this point in the history
  4. Update to more readable fix based on PR review feedback

    Simplifies the conditional to reload configuration based on the interval set by
    `APICAST_CONFIGURATION_CACHE`.
    
    Also conditionally sets the interval to schedule.
    coderbydesign authored and tkan145 committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    647e0dd View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge pull request #1482 from tkan145/backport-1468

    Ensure we don't schedule reloading configuration when reloading is disabled
    tkan145 authored Jul 11, 2024
    Configuration menu
    Copy the full SHA
    0eb5ecb View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. [http_authorization] Check for nil value when decode based64 value

    Performing a match on a nil value results in an exception being thrown
    and bypassing the entire authorization validation process.
    tkan145 committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d3b7604 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge pull request #1507 from tkan145/backport-THREESCALE-11435-2.15

    [THREESCALE-11435] Check for nil value when decode based64 value
    tkan145 authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a95ab3a View commit details
    Browse the repository at this point in the history
Loading