Repository navigation
Fix batched 2D vector rotation - #2501
Merged
Merged
Conversation
QinXi-ai
marked this pull request as ready for review
August 14, 2026 05:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
VectorFieldcalls vectorized functions with an(N, 2)array of sample coordinates. Passing that array torotate_vector, as in the curl example from #2336, currently attempts to multiply it by a 3x3 rotation matrix and raises a shape-mismatchValueError.The helper already accepts a single 2D vector in its public usage. Supporting the vectorized form lets the same helper work naturally with
VectorFieldand restores the pattern used by existing Manim examples.Closes #2336.
Proposed changes
Test
Code:
The issue reproduction was also exercised through the real
VectorFieldpath:Result:
4 passedfield.sample_coords.shape == (561, 2)result.shape == (561, 2)and all values are finitecompileallcompleted successfully