fix(render): Append .cshtml extension to custom field paths#63
Merged
Conversation
The rendering logic for custom Razor fields was failing because it passed the field's filename without the .cshtml extension to Html.Partial. In the target environment, the rendering engine does not automatically append the extension, which caused a compilation error. This change explicitly concatenates the ".cshtml" string to the path, resolving the issue for all custom fields.
Contributor
|
@ropalko could you check and if ok, pull/merge/version-bump/publish? |
Contributor
|
@ropalko if this was wrong, pls ensure that our dev-setup has a plausible example so we would see if it doesn't work. my guess is that we originally stored the file name with extension, and that out test-data is therefor wrong...? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rendering logic for custom Razor fields was failing because it passed the field's filename without the .cshtml extension to Html.Partial.
In the target environment, the rendering engine does not automatically append the extension, which caused a compilation error. This change explicitly concatenates the ".cshtml" string to the path, resolving the issue for all custom fields.