Skip to content

Commit fc38125

Browse files
committed
Cover todo schema rejection at Gemini request boundary
1 parent 7e6dec1 commit fc38125

1 file changed

Lines changed: 45 additions & 0 deletions

File tree

‎crates/jcode-provider-gemini-runtime/tests/every_provider_sends_clean_schemas.rs‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,51 @@ fn assert_descriptions_survive(wire: &Value, provider: &str) {
7272
);
7373
}
7474

75+
#[test]
76+
fn todo_add_missing_properties_is_repaired_on_gemini_wire_paths() {
77+
let schema = serde_json::json!({
78+
"type": "object",
79+
"properties": {
80+
"add": {
81+
"type": "array",
82+
"items": {
83+
"type": "object",
84+
"required": ["content", "status", "priority", "id", "confidence"],
85+
"additionalProperties": true
86+
}
87+
}
88+
}
89+
});
90+
let tools = vec![ToolDefinition {
91+
name: "todo".to_string(),
92+
description: "Screenshot regression".to_string(),
93+
input_schema: schema.clone(),
94+
defer_loading: false,
95+
}];
96+
let built = jcode_provider_gemini::build_tools(&tools).expect("tools");
97+
let wire = serde_json::to_value(&built).expect("serialize request tools");
98+
let direct = &wire[0]["functionDeclarations"][0]["parameters"];
99+
// Use the exact model name from the failing session to exercise routing.
100+
let antigravity = jcode_provider_antigravity::antigravity_compatible_schema(
101+
&schema,
102+
"gemini-3.8-flash-tiered",
103+
);
104+
for (route, parameters) in [("direct", direct), ("antigravity", &antigravity)] {
105+
assert_eq!(
106+
parameters["properties"]["add"]["type"], "array",
107+
"{route}: {parameters}"
108+
);
109+
let item = &parameters["properties"]["add"]["items"];
110+
assert_eq!(item["type"], "object", "{route}: {parameters}");
111+
assert!(item.get("required").is_none(), "{route}: {parameters}");
112+
let errors = jcode_schema_dialect::must_not_contain_unsupported_constructs(
113+
parameters,
114+
&jcode_schema_dialect::registry::GEMINI,
115+
);
116+
assert!(errors.is_empty(), "{route}: {errors:?}");
117+
}
118+
}
119+
75120
#[test]
76121
fn gemini_sends_a_clean_schema_for_the_hostile_tool() {
77122
let built = jcode_provider_gemini::build_tools(&hostile_tool()).expect("tools");

0 commit comments

Comments
 (0)