|
| 1 | +fn completion_report_messages(app: &App) -> Vec<&DisplayMessage> { |
| 2 | + app.display_messages |
| 3 | + .iter() |
| 4 | + .filter(|message| message.title.as_deref() == Some("Todo completion")) |
| 5 | + .collect() |
| 6 | +} |
| 7 | + |
| 8 | +fn completion_report_todos(status: &str) -> Vec<crate::todo::TodoItem> { |
| 9 | + (0..12) |
| 10 | + .map(|index| crate::todo::TodoItem { |
| 11 | + id: format!("report-{index}"), |
| 12 | + content: format!("Report task {index}"), |
| 13 | + status: status.into(), |
| 14 | + priority: "high".into(), |
| 15 | + completion_confidence: Some(crate::todo::ConfidenceState::Validated), |
| 16 | + details: Some(format!("Evidence for task {index}")), |
| 17 | + ..Default::default() |
| 18 | + }) |
| 19 | + .collect() |
| 20 | +} |
| 21 | + |
| 22 | +#[test] |
| 23 | +fn todo_completion_report_is_full_nonblocking_and_independent_of_poke() { |
| 24 | + with_temp_jcode_home(|| { |
| 25 | + let mut app = create_test_app(); |
| 26 | + app.auto_poke_incomplete_todos = false; |
| 27 | + app.auto_poke_default_on = false; |
| 28 | + let session_id = app.session.id.clone(); |
| 29 | + assert!(!app.refresh_completed_todo_report(true)); |
| 30 | + let mut todos = completion_report_todos("pending"); |
| 31 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 32 | + assert!(!app.refresh_completed_todo_report(true)); |
| 33 | + todos = completion_report_todos("completed"); |
| 34 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 35 | + crate::todo::save_plan( |
| 36 | + &session_id, |
| 37 | + &crate::todo::TodoPlan { |
| 38 | + user_intention: Some("Show all evidence without another agent turn".into()), |
| 39 | + understands_user_intent: Some(crate::todo::IntentUnderstanding::Clear), |
| 40 | + understands_user_intent_history: vec![ |
| 41 | + crate::todo::IntentUnderstanding::Uncertain, |
| 42 | + crate::todo::IntentUnderstanding::Clear, |
| 43 | + ], |
| 44 | + }, |
| 45 | + ) |
| 46 | + .unwrap(); |
| 47 | + crate::todo::save_goals( |
| 48 | + &session_id, |
| 49 | + &[crate::todo::TodoGoal { |
| 50 | + feedback_loop: Some("Real acceptance workflow is unavailable".into()), |
| 51 | + feedback_loop_relevance: Some( |
| 52 | + crate::todo::FeedbackLoopRelevance::AcceptanceBlocked, |
| 53 | + ), |
| 54 | + iteration_maturity: Some(crate::todo::IterationMaturity::ConstraintsExhausted), |
| 55 | + stopping_evidence: Some("External service unavailable".into()), |
| 56 | + ..Default::default() |
| 57 | + }], |
| 58 | + ) |
| 59 | + .unwrap(); |
| 60 | + |
| 61 | + assert!(app.refresh_completed_todo_report(true)); |
| 62 | + let reports = completion_report_messages(&app); |
| 63 | + assert_eq!(reports.len(), 1); |
| 64 | + let report = (*reports[0]).clone(); |
| 65 | + let content = &report.content; |
| 66 | + for expected in [ |
| 67 | + "Report task 0", |
| 68 | + "Report task 11", |
| 69 | + "Evidence for task 11", |
| 70 | + "acceptance_blocked", |
| 71 | + "uncertain", |
| 72 | + "External service unavailable", |
| 73 | + "Show all evidence without another agent turn", |
| 74 | + ] { |
| 75 | + assert!(content.contains(expected), "missing {expected}: {content}"); |
| 76 | + } |
| 77 | + assert!(app.queued_messages.is_empty()); |
| 78 | + assert!(!app.pending_queued_dispatch); |
| 79 | + assert!(!app.refresh_completed_todo_report(true)); |
| 80 | + assert_eq!(completion_report_messages(&app).len(), 1); |
| 81 | + |
| 82 | + // The actual renderer keeps the entire report at narrow terminal widths. |
| 83 | + for width in [20, 40, 80] { |
| 84 | + let lines = crate::tui::ui::render_system_message( |
| 85 | + &report, |
| 86 | + width, |
| 87 | + crate::config::DiffDisplayMode::Off, |
| 88 | + ); |
| 89 | + let plain = lines |
| 90 | + .iter() |
| 91 | + .map(|line| line.to_string()) |
| 92 | + .collect::<Vec<_>>() |
| 93 | + .join("\n"); |
| 94 | + let normalized = plain.split_whitespace().collect::<Vec<_>>().join(" "); |
| 95 | + assert!(normalized.contains("Report task 11"), "{plain}"); |
| 96 | + if width >= 40 { |
| 97 | + assert!(plain.contains("acceptance_blocked"), "{plain}"); |
| 98 | + } |
| 99 | + for line in &lines { |
| 100 | + assert!(line.width() <= width as usize, "width {width}: {line}"); |
| 101 | + } |
| 102 | + } |
| 103 | + }); |
| 104 | +} |
| 105 | + |
| 106 | +#[test] |
| 107 | +fn todo_completion_report_refreshes_evidence_and_preserves_previous_cycles() { |
| 108 | + with_temp_jcode_home(|| { |
| 109 | + let mut app = create_test_app(); |
| 110 | + let session_id = app.session.id.clone(); |
| 111 | + let mut todos = completion_report_todos("completed"); |
| 112 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 113 | + assert!(app.refresh_completed_todo_report(true)); |
| 114 | + todos[0].details = Some("Additional acceptance evidence".into()); |
| 115 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 116 | + assert!(app.refresh_completed_todo_report(true)); |
| 117 | + assert_eq!(completion_report_messages(&app).len(), 1); |
| 118 | + assert!( |
| 119 | + completion_report_messages(&app)[0] |
| 120 | + .content |
| 121 | + .contains("Additional acceptance evidence") |
| 122 | + ); |
| 123 | + |
| 124 | + todos[0].status = "in_progress".into(); |
| 125 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 126 | + assert!(!app.refresh_completed_todo_report(true)); |
| 127 | + todos[0].status = "completed".into(); |
| 128 | + todos[0].content = "Second cycle task".into(); |
| 129 | + crate::todo::save_todos(&session_id, &todos).unwrap(); |
| 130 | + assert!(app.refresh_completed_todo_report(true)); |
| 131 | + let reports = completion_report_messages(&app); |
| 132 | + assert_eq!(reports.len(), 2); |
| 133 | + assert!(!reports[0].content.contains("Second cycle task")); |
| 134 | + assert!(reports[1].content.contains("Second cycle task")); |
| 135 | + assert!(app.queued_messages.is_empty()); |
| 136 | + }); |
| 137 | +} |
| 138 | + |
| 139 | +#[test] |
| 140 | +fn todo_completion_report_uses_remote_session_and_runs_before_other_gates() { |
| 141 | + with_temp_jcode_home(|| { |
| 142 | + let mut app = create_test_app(); |
| 143 | + let wrapper = app.session.id.clone(); |
| 144 | + crate::todo::save_todos(&wrapper, &completion_report_todos("pending")).unwrap(); |
| 145 | + let remote = "session_completion_report_remote"; |
| 146 | + app.is_remote = true; |
| 147 | + app.remote_session_id = Some(remote.into()); |
| 148 | + crate::todo::save_todos(remote, &completion_report_todos("completed")).unwrap(); |
| 149 | + app.auto_poke_default_on = false; |
| 150 | + app.auto_poke_incomplete_todos = false; |
| 151 | + assert!(!app.schedule_auto_poke_followup_if_needed()); |
| 152 | + assert_eq!(completion_report_messages(&app).len(), 1); |
| 153 | + assert!(app.queued_messages.is_empty()); |
| 154 | + }); |
| 155 | +} |
0 commit comments