Skip to content

Commit aefdf53

Browse files
committed
Automatically display full todo completion reports
1 parent 936f247 commit aefdf53

8 files changed

Lines changed: 252 additions & 0 deletions

File tree

‎crates/jcode-tui/src/tui/app.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ mod swarm_hint;
124124
mod terminal_liveness;
125125
mod terminal_setup_command;
126126
mod terminal_title;
127+
mod todo_completion;
127128
mod todos_view;
128129
pub(crate) use todos_view::pinned_todos_payload_for_session;
129130
mod tui_lifecycle;
@@ -1530,6 +1531,8 @@ pub struct App {
15301531
/// Hash of the todo payload rendered into the inline chat todo card, used
15311532
/// to keep the card live-updating while it stays in the transcript.
15321533
todo_card_rendered_hash: u64,
1534+
/// Tracks the display-only full report for the current completed todo cycle.
1535+
todo_completion_report: todo_completion::TodoCompletionReportState,
15331536
/// JSON payload for the pinned todo band (display.pin_todos). `None` when
15341537
/// the feature is off or the session has no todos. Refreshed on tick.
15351538
/// The renderer wiring for these three fields is landing separately, so

‎crates/jcode-tui/src/tui/app/input.rs‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1579,6 +1579,9 @@ impl App {
15791579
}
15801580

15811581
pub(super) fn schedule_auto_poke_followup_if_needed(&mut self) -> bool {
1582+
// Completion is visible even with /poke off, and never needs another
1583+
// model turn merely to show the plan's remaining weaknesses.
1584+
self.refresh_completed_todo_report(true);
15821585
// Aggregated weak-point digests are disabled. Discard legacy observations
15831586
// without queuing a continuation or notice, including for remote sessions.
15841587
let observation_session_id = self

‎crates/jcode-tui/src/tui/app/local.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ pub(super) fn handle_tick(app: &mut App) -> bool {
129129
}
130130
needs_redraw |= app.refresh_todos_view_if_needed();
131131
needs_redraw |= app.refresh_todo_card_if_needed();
132+
needs_redraw |= app.refresh_completed_todo_report(false);
132133
needs_redraw |= app.refresh_pinned_todos_if_needed();
133134
needs_redraw |= app.prune_irrelevant_background_tasks();
134135
needs_redraw |= app.refresh_side_panel_linked_content_if_due();

‎crates/jcode-tui/src/tui/app/remote.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ pub(super) async fn handle_tick(app: &mut App, remote: &mut RemoteConnection) ->
196196

197197
needs_redraw |= app.refresh_todos_view_if_needed();
198198
needs_redraw |= app.refresh_todo_card_if_needed();
199+
needs_redraw |= app.refresh_completed_todo_report(false);
199200
needs_redraw |= app.refresh_pinned_todos_if_needed();
200201
needs_redraw |= app.prune_irrelevant_background_tasks();
201202
needs_redraw |= app.refresh_side_panel_linked_content_if_due();

‎crates/jcode-tui/src/tui/app/tests.rs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ include!("tests/reasoning_region.rs");
5151
include!("tests/smoothness_benchmark.rs");
5252
include!("tests/hotkey_feedback_e2e.rs");
5353
include!("tests/todo_card.rs");
54+
include!("tests/todo_completion.rs");
5455
include!("tests/issue_496_input_routing.rs");
5556
include!("tests/oauth_login_progress.rs");
5657
include!("tests/issue_544_paste_enter.rs");
Lines changed: 155 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,155 @@
1+
fn completion_report_messages(app: &App) -> Vec<&DisplayMessage> {
2+
app.display_messages
3+
.iter()
4+
.filter(|message| message.title.as_deref() == Some("Todo completion"))
5+
.collect()
6+
}
7+
8+
fn completion_report_todos(status: &str) -> Vec<crate::todo::TodoItem> {
9+
(0..12)
10+
.map(|index| crate::todo::TodoItem {
11+
id: format!("report-{index}"),
12+
content: format!("Report task {index}"),
13+
status: status.into(),
14+
priority: "high".into(),
15+
completion_confidence: Some(crate::todo::ConfidenceState::Validated),
16+
details: Some(format!("Evidence for task {index}")),
17+
..Default::default()
18+
})
19+
.collect()
20+
}
21+
22+
#[test]
23+
fn todo_completion_report_is_full_nonblocking_and_independent_of_poke() {
24+
with_temp_jcode_home(|| {
25+
let mut app = create_test_app();
26+
app.auto_poke_incomplete_todos = false;
27+
app.auto_poke_default_on = false;
28+
let session_id = app.session.id.clone();
29+
assert!(!app.refresh_completed_todo_report(true));
30+
let mut todos = completion_report_todos("pending");
31+
crate::todo::save_todos(&session_id, &todos).unwrap();
32+
assert!(!app.refresh_completed_todo_report(true));
33+
todos = completion_report_todos("completed");
34+
crate::todo::save_todos(&session_id, &todos).unwrap();
35+
crate::todo::save_plan(
36+
&session_id,
37+
&crate::todo::TodoPlan {
38+
user_intention: Some("Show all evidence without another agent turn".into()),
39+
understands_user_intent: Some(crate::todo::IntentUnderstanding::Clear),
40+
understands_user_intent_history: vec![
41+
crate::todo::IntentUnderstanding::Uncertain,
42+
crate::todo::IntentUnderstanding::Clear,
43+
],
44+
},
45+
)
46+
.unwrap();
47+
crate::todo::save_goals(
48+
&session_id,
49+
&[crate::todo::TodoGoal {
50+
feedback_loop: Some("Real acceptance workflow is unavailable".into()),
51+
feedback_loop_relevance: Some(
52+
crate::todo::FeedbackLoopRelevance::AcceptanceBlocked,
53+
),
54+
iteration_maturity: Some(crate::todo::IterationMaturity::ConstraintsExhausted),
55+
stopping_evidence: Some("External service unavailable".into()),
56+
..Default::default()
57+
}],
58+
)
59+
.unwrap();
60+
61+
assert!(app.refresh_completed_todo_report(true));
62+
let reports = completion_report_messages(&app);
63+
assert_eq!(reports.len(), 1);
64+
let report = (*reports[0]).clone();
65+
let content = &report.content;
66+
for expected in [
67+
"Report task 0",
68+
"Report task 11",
69+
"Evidence for task 11",
70+
"acceptance&#95;blocked",
71+
"uncertain",
72+
"External service unavailable",
73+
"Show all evidence without another agent turn",
74+
] {
75+
assert!(content.contains(expected), "missing {expected}: {content}");
76+
}
77+
assert!(app.queued_messages.is_empty());
78+
assert!(!app.pending_queued_dispatch);
79+
assert!(!app.refresh_completed_todo_report(true));
80+
assert_eq!(completion_report_messages(&app).len(), 1);
81+
82+
// The actual renderer keeps the entire report at narrow terminal widths.
83+
for width in [20, 40, 80] {
84+
let lines = crate::tui::ui::render_system_message(
85+
&report,
86+
width,
87+
crate::config::DiffDisplayMode::Off,
88+
);
89+
let plain = lines
90+
.iter()
91+
.map(|line| line.to_string())
92+
.collect::<Vec<_>>()
93+
.join("\n");
94+
let normalized = plain.split_whitespace().collect::<Vec<_>>().join(" ");
95+
assert!(normalized.contains("Report task 11"), "{plain}");
96+
if width >= 40 {
97+
assert!(plain.contains("acceptance_blocked"), "{plain}");
98+
}
99+
for line in &lines {
100+
assert!(line.width() <= width as usize, "width {width}: {line}");
101+
}
102+
}
103+
});
104+
}
105+
106+
#[test]
107+
fn todo_completion_report_refreshes_evidence_and_preserves_previous_cycles() {
108+
with_temp_jcode_home(|| {
109+
let mut app = create_test_app();
110+
let session_id = app.session.id.clone();
111+
let mut todos = completion_report_todos("completed");
112+
crate::todo::save_todos(&session_id, &todos).unwrap();
113+
assert!(app.refresh_completed_todo_report(true));
114+
todos[0].details = Some("Additional acceptance evidence".into());
115+
crate::todo::save_todos(&session_id, &todos).unwrap();
116+
assert!(app.refresh_completed_todo_report(true));
117+
assert_eq!(completion_report_messages(&app).len(), 1);
118+
assert!(
119+
completion_report_messages(&app)[0]
120+
.content
121+
.contains("Additional acceptance evidence")
122+
);
123+
124+
todos[0].status = "in_progress".into();
125+
crate::todo::save_todos(&session_id, &todos).unwrap();
126+
assert!(!app.refresh_completed_todo_report(true));
127+
todos[0].status = "completed".into();
128+
todos[0].content = "Second cycle task".into();
129+
crate::todo::save_todos(&session_id, &todos).unwrap();
130+
assert!(app.refresh_completed_todo_report(true));
131+
let reports = completion_report_messages(&app);
132+
assert_eq!(reports.len(), 2);
133+
assert!(!reports[0].content.contains("Second cycle task"));
134+
assert!(reports[1].content.contains("Second cycle task"));
135+
assert!(app.queued_messages.is_empty());
136+
});
137+
}
138+
139+
#[test]
140+
fn todo_completion_report_uses_remote_session_and_runs_before_other_gates() {
141+
with_temp_jcode_home(|| {
142+
let mut app = create_test_app();
143+
let wrapper = app.session.id.clone();
144+
crate::todo::save_todos(&wrapper, &completion_report_todos("pending")).unwrap();
145+
let remote = "session_completion_report_remote";
146+
app.is_remote = true;
147+
app.remote_session_id = Some(remote.into());
148+
crate::todo::save_todos(remote, &completion_report_todos("completed")).unwrap();
149+
app.auto_poke_default_on = false;
150+
app.auto_poke_incomplete_todos = false;
151+
assert!(!app.schedule_auto_poke_followup_if_needed());
152+
assert_eq!(completion_report_messages(&app).len(), 1);
153+
assert!(app.queued_messages.is_empty());
154+
});
155+
}
Lines changed: 86 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,86 @@
1+
//! Display-only completion reports. Assessment weaknesses never enqueue work.
2+
3+
use super::App;
4+
use crate::tui::DisplayMessage;
5+
use std::collections::hash_map::DefaultHasher;
6+
use std::hash::{Hash, Hasher};
7+
use std::time::{Duration, Instant};
8+
9+
pub(super) const REPORT_TITLE: &str = "Todo completion";
10+
11+
#[derive(Default)]
12+
pub(super) struct TodoCompletionReportState {
13+
session_id: Option<String>,
14+
fingerprint: Option<u64>,
15+
checked_at: Option<Instant>,
16+
}
17+
18+
impl App {
19+
/// Render every finished item and its assessments without entering the
20+
/// provider conversation or depending on auto-poke being enabled.
21+
pub(super) fn refresh_completed_todo_report(&mut self, force: bool) -> bool {
22+
if crate::tui::is_ssh_remote() {
23+
return false;
24+
}
25+
let Some(session_id) = self.active_client_session_id().map(str::to_owned) else {
26+
return false;
27+
};
28+
if self.todo_completion_report.session_id.as_deref() != Some(&session_id) {
29+
self.todo_completion_report = TodoCompletionReportState {
30+
session_id: Some(session_id.clone()),
31+
..Default::default()
32+
};
33+
}
34+
if !force
35+
&& self
36+
.todo_completion_report
37+
.checked_at
38+
.is_some_and(|at| at.elapsed() < Duration::from_secs(1))
39+
{
40+
return false;
41+
}
42+
self.todo_completion_report.checked_at = Some(Instant::now());
43+
44+
let todos = crate::todo::load_todos(&session_id).unwrap_or_default();
45+
if todos.is_empty()
46+
|| todos.iter().any(|todo| {
47+
!crate::todo::todo_status_is_completed(&todo.status)
48+
&& !crate::todo::todo_status_is_cancelled(&todo.status)
49+
})
50+
{
51+
// Reopening work starts a new cycle; preserve its earlier report.
52+
self.todo_completion_report.fingerprint = None;
53+
return false;
54+
}
55+
let plan = crate::todo::load_plan(&session_id).unwrap_or_default();
56+
let goals = crate::todo::load_goals(&session_id).unwrap_or_default();
57+
let Ok(serialized) = serde_json::to_vec(&(&todos, &plan, &goals)) else {
58+
return false;
59+
};
60+
let mut hasher = DefaultHasher::new();
61+
serialized.hash(&mut hasher);
62+
let fingerprint = hasher.finish();
63+
if self.todo_completion_report.fingerprint == Some(fingerprint) {
64+
return false;
65+
}
66+
67+
let content =
68+
crate::todo::completion_report::render_completion_report(&todos, &plan, &goals);
69+
let updating = self.todo_completion_report.fingerprint.is_some();
70+
self.todo_completion_report.fingerprint = Some(fingerprint);
71+
// Late evidence/assessment writes update this cycle's report rather
72+
// than flooding the transcript with a second full copy.
73+
if updating
74+
&& let Some(index) = self
75+
.display_messages
76+
.iter()
77+
.rposition(|message| message.title.as_deref() == Some(REPORT_TITLE))
78+
{
79+
return self.replace_display_message_content(index, content);
80+
}
81+
let mut message = DisplayMessage::system(content);
82+
message.title = Some(REPORT_TITLE.to_string());
83+
self.push_display_message(message);
84+
true
85+
}
86+
}

‎crates/jcode-tui/src/tui/app/tui_lifecycle.rs‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,7 @@ impl App {
605605
todos_view_updated_at_ms: 0,
606606
todos_view_rendered_hash: 0,
607607
todo_card_rendered_hash: 0,
608+
todo_completion_report: Default::default(),
608609
pinned_todos_payload: None,
609610
pinned_todos_rendered_hash: 0,
610611
pinned_todos_checked_at: None,
@@ -1091,6 +1092,7 @@ impl App {
10911092
todos_view_updated_at_ms: 0,
10921093
todos_view_rendered_hash: 0,
10931094
todo_card_rendered_hash: 0,
1095+
todo_completion_report: Default::default(),
10941096
pinned_todos_payload: None,
10951097
pinned_todos_rendered_hash: 0,
10961098
pinned_todos_checked_at: None,

0 commit comments

Comments
 (0)