Skip to content

Commit 6a67d7f

Browse files
committed
Hide delivery-state labels from pinned todo cards
1 parent 30ebf52 commit 6a67d7f

2 files changed

Lines changed: 7 additions & 25 deletions

File tree

‎crates/jcode-tui/src/tui/ui_messages.rs‎

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,21 +1542,6 @@ fn todo_goal_score_segments(goal: &crate::todo::TodoGoal) -> Vec<Vec<Span<'stati
15421542
]);
15431543
}
15441544

1545-
// Delivery is progress toward the outcome, not a quality gate. Keep it
1546-
// visible and visually separate from failures so it cannot read as one.
1547-
if let Some(state) = goal.delivery_state {
1548-
let color = if state >= crate::todo::DeliveryState::WorkflowValidated {
1549-
todo_score_color()
1550-
} else if state == crate::todo::DeliveryState::Integrated {
1551-
todo_warning_color()
1552-
} else {
1553-
todo_failure_color()
1554-
};
1555-
segments.push(vec![
1556-
Span::styled("Delivery ", Style::default().fg(todo_label_color())),
1557-
Span::styled(state.as_str().to_string(), Style::default().fg(color)),
1558-
]);
1559-
}
15601545
segments
15611546
}
15621547

‎crates/jcode-tui/src/tui/ui_messages/tests.rs‎

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1312,9 +1312,8 @@ fn render_todos_message_shows_goal_scores_without_verbose_feedback() {
13121312
.collect::<Vec<_>>()
13131313
.join("\n");
13141314

1315-
for assessment in ["Closed feedback loop strong", "Delivery workflow_validated"] {
1316-
assert!(plain.contains(assessment), "{plain}");
1317-
}
1315+
assert!(plain.contains("Closed feedback loop strong"), "{plain}");
1316+
assert!(!plain.contains("Delivery "), "{plain}");
13181317
assert!(!plain.contains("Relevance representative"), "{plain}");
13191318
assert!(!plain.contains("Coverage main_paths"), "{plain}");
13201319
// Only the plan-level assessment renders above the groups.
@@ -1543,7 +1542,7 @@ fn render_todos_message_collapses_passing_quality_gates() {
15431542
.join("\n");
15441543

15451544
assert!(plain.contains("✓ All quality gates passing"), "{plain}");
1546-
assert!(plain.contains("Delivery outcome_delivered"), "{plain}");
1545+
assert!(!plain.contains("Delivery "), "{plain}");
15471546
assert!(!plain.contains("Closed feedback loop closed"), "{plain}");
15481547
assert!(!plain.contains("Relevance acceptance_aligned"), "{plain}");
15491548
assert!(
@@ -1592,7 +1591,7 @@ fn render_todos_message_wraps_goal_scores_at_narrow_widths() {
15921591
.join("\n");
15931592

15941593
assert!(plain.contains("Closed feedback loop strong"), "{plain}");
1595-
assert!(plain.contains("Delivery workflow_validated"), "{plain}");
1594+
assert!(!plain.contains("Delivery "), "{plain}");
15961595
assert!(
15971596
lines.iter().all(|line| line.width() <= 38),
15981597
"card exceeded its 38-column content budget: {plain}"
@@ -1724,7 +1723,7 @@ fn render_todo_tool_result_uses_borderless_card_with_goal_scores() {
17241723
assert!(plain.contains("Closed feedback loop strong"), "{plain}");
17251724
assert!(plain.contains("Relevance missing"), "{plain}");
17261725
assert!(plain.contains("Coverage missing"), "{plain}");
1727-
assert!(plain.contains("Delivery workflow_validated"), "{plain}");
1726+
assert!(!plain.contains("Delivery "), "{plain}");
17281727
assert!(
17291728
plain.contains("● Render the todo result · plausible"),
17301729
"{plain}"
@@ -2229,10 +2228,8 @@ fn render_ownership_gated_todo_result_keeps_the_full_card() {
22292228

22302229
assert!(plain.contains("ship outcome ●"), "{plain}");
22312230
assert!(plain.contains("Deliver the complete workflow"), "{plain}");
2232-
assert!(
2233-
plain.contains("✓ All quality gates passing · Delivery workflow_validated"),
2234-
"{plain}"
2235-
);
2231+
assert!(plain.contains("✓ All quality gates passing"), "{plain}");
2232+
assert!(!plain.contains("Delivery "), "{plain}");
22362233
assert!(!plain.contains("todo 1 items"), "{plain}");
22372234
}
22382235

0 commit comments

Comments
 (0)