Skip to content

Добавлена ссылка на владельца для Module#570

Merged
theshadowco merged 1 commit into
developfrom
feature/moduleOwner
Jan 13, 2026
Merged

Добавлена ссылка на владельца для Module#570
theshadowco merged 1 commit into
developfrom
feature/moduleOwner

Conversation

@theshadowco

@theshadowco theshadowco commented Jan 12, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Описание

Связанные задачи

Closes #557

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Дополнительно

Summary by CodeRabbit

Release Notes

  • Refactor
    • Enhanced module ownership reference capabilities through improved interface definitions and implementation methods.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The PR introduces a getOwner() method to the Module interface and implements it in the CommonModule class. This allows callers to determine which MDO reference owns a given module by returning the module's internal reference.

Changes

Cohort / File(s) Summary
Module interface and implementation
src/main/java/com/github/_1c_syntax/bsl/mdo/Module.java, src/main/java/com/github/_1c_syntax/bsl/mdo/CommonModule.java		 Added getOwner() method to Module interface and implemented it in CommonModule class. The implementation returns the module's internal mdoReference to indicate self-ownership. Includes necessary imports and Javadoc.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A module now knows who it belongs to,
With getOwner() calling the day—
Self-aware and proud, it speaks its truth,
🐰 hops away ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title is in Russian ('Added reference to owner for Module') and clearly describes the main change: adding owner information to Module.
Linked Issues check ✅ Passed The PR implements the core requirement from issue #557 by adding an owner reference (getOwner() method) to Module and CommonModule classes.
Out of Scope Changes check ✅ Passed All changes are focused on adding the owner reference functionality to Module and CommonModule as specified in issue #557, with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4247395 and e53bad4.

⛔ Files ignored due to path filters (14)
  • src/test/resources/fixtures/mdclasses/CommonModules.ГлобальныйОбщийМодуль.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ГлобальныйОбщийМодуль_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульВызовСервера.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульВызовСервера_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПовтИспВызов.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПовтИспВызов_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПовтИспСеанс.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПовтИспСеанс_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПолныйеПрава.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ОбщийМодульПолныйеПрава_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ПростойОбщийМодуль.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/mdclasses/CommonModules.ПростойОбщийМодуль_edt.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/ssl_3_1/CommonModules.АвтономнаяРабота.json is excluded by !src/test/resources/**
  • src/test/resources/fixtures/ssl_3_1/CommonModules.АвтономнаяРабота_edt.json is excluded by !src/test/resources/**
📒 Files selected for processing (2)
  • src/main/java/com/github/_1c_syntax/bsl/mdo/CommonModule.java
  • src/main/java/com/github/_1c_syntax/bsl/mdo/Module.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: QA
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (25, macOS-latest)
  • GitHub Check: build (25, macOS-latest)
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: build (17, macOS-latest)
  • GitHub Check: build (21, windows-latest)
🔇 Additional comments (2)
src/main/java/com/github/_1c_syntax/bsl/mdo/CommonModule.java (1)

124-127: LGTM!

The implementation correctly returns mdoReference since CommonModule is a top-level MDO and acts as its own owner. The inline comment clarifies this design decision well.

src/main/java/com/github/_1c_syntax/bsl/mdo/Module.java (1)

54-57: All Module implementations correctly provide getOwner().

Both CommonModule and ObjectModule have been properly updated. CommonModule explicitly implements the method, and ObjectModule provides it via Lombok's @Value annotation through its owner field.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud

sonarqubecloud Bot commented Jan 12, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jan 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

  603 files  ±0    603 suites  ±0   8m 54s ⏱️ +2s
  284 tests ±0    284 ✅ ±0  0 💤 ±0  0 ❌ ±0 
2 646 runs  ±0  2 646 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e53bad4. ± Comparison against base commit 4247395.

♻️ This comment has been updated with latest results.

@theshadowco
theshadowco merged commit 60f1bea into develop Jan 13, 2026
25 checks passed
@theshadowco
theshadowco deleted the feature/moduleOwner branch January 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[NEW] Добавить владельца модуля

1 participant

@theshadowco