Добавлена обработка ошибки чтения содержимого xdto пакета#559
Conversation
📝 WalkthroughWalkthroughTwo XDTOPackageConverter classes now include try-catch error handling around ExtendXStream.read operations. On exceptions, both default to XdtoPackageData.EMPTY instead of propagating errors, enabling graceful degradation when package data is corrupted or unreadable. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
src/test/resources/ext/designer/mdclasses/src/cf/XDTOPackages/ПакетXDTO1/Ext/Package.binis excluded by!**/*.bin,!src/test/resources/**src/test/resources/ext/edt/mdclasses/configuration/src/XDTOPackages/ПакетXDTO1/Package.xdtois excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Configuration.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/Configuration_edt.jsonis excluded by!src/test/resources/**src/test/resources/fixtures/mdclasses/XDTOPackages.ПакетXDTO1.jsonis excluded by!src/test/resources/**
📒 Files selected for processing (2)
src/main/java/com/github/_1c_syntax/bsl/reader/designer/converter/XDTOPackageConverter.javasrc/main/java/com/github/_1c_syntax/bsl/reader/edt/converter/XDTOPackageConverter.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: publish-test-results
🔇 Additional comments (4)
src/main/java/com/github/_1c_syntax/bsl/reader/designer/converter/XDTOPackageConverter.java (2)
25-25: LGTM - Import supports error handling fallback.The import is necessary for the
XdtoPackageData.EMPTYconstant used in the error handling logic.
51-51: LGTM - Field is set consistently.The
setValuecall is correctly placed outside the try-catch block, ensuring the field is always populated with either valid data or the EMPTY fallback.src/main/java/com/github/_1c_syntax/bsl/reader/edt/converter/XDTOPackageConverter.java (2)
25-25: LGTM - Import supports error handling fallback.The import is necessary for the
XdtoPackageData.EMPTYconstant used in the error handling logic.
49-49: LGTM - Field is set consistently.The
setValuecall is correctly placed outside the try-catch block, ensuring the field is always populated with either valid data or the EMPTY fallback.
This reverts commit ad64a2f.
|
1 participant
Описание
Добавлена обработка ошибки чтения содержимого xdto пакета
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Дополнительно
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.