fix(inlayhints): не показывать тип переменной, если имя уже несёт имя типа by nixel2007 · Pull Request #4267 · 1c-syntax/bsl-language-server

nixel2007 · 2026-07-14T08:02:45Z

Описание

Инлайн-хинт выведенного типа переменной больше не выводится, когда имя переменной уже содержит имя типа. Раньше для присваивания вида Массив = ... с выведенным типом Массив хинт : Массив дублировал то, что и так видно в имени переменной, и лишь шумел.

Проверка добавлена в VariableTypeInlayHintSupplier: если имя переменной содержит имя типа (регистронезависимо), хинт не строится. Механизм намеренно повторяет уже принятое в проекте подавление подсказок имён параметров с совпадающим именем аргумента (SourceDefinedMethodCallInlayHintCollector использует тот же Strings.CI.contains) — как и просил автор задачи.

Так Массив = ... и МассивТоваров = ... (тип Массив) подсказку больше не получают, а Копия = Источник (тип Массив) — по-прежнему получает.

Связанные задачи

Closes #4247

Чеклист

Общие

Ветка PR обновлена из develop
Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
Изменения покрыты тестами
Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Дополнительно

Затронуты:

src/main/java/.../inlayhints/VariableTypeInlayHintSupplier.java — логика подавления + javadoc;
src/test/java/.../inlayhints/VariableTypeInlayHintSupplierTest.java — новый тест testNoHintWhenVariableNameContainsTypeName.

🤖 Generated with Claude Code

Generated by Claude Code

Summary by CodeRabbit

Bug Fixes
- Suppressed redundant variable type inlay hints when the variable name already includes the inferred type (case-insensitive match).
- Refined inlay-hint generation to avoid producing hints in trivial or non-applicable scenarios.
Tests
- Added a test ensuring no variable type inlay hints are shown when the variable name already contains the inferred type name.

… типа Хинт выведенного типа переменной подавляется, когда имя переменной уже содержит имя типа (например «Массив» с типом «Массив»): подсказка лишь дублирует видимое в имени и шумит. По аналогии с подавлением подсказок имён параметров с совпадающим именем аргумента. Closes #4247 Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01SSt7bML8BDg8DGV9BRDdjo

coderabbitai · 2026-07-14T08:03:07Z

Warning

Review limit reached

@nixel2007, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 31 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b990960b-11ad-4f44-8749-b47f35c5c409

📥 Commits

Reviewing files that changed from the base of the PR and between 7449413 and e6b22ba.

📒 Files selected for processing (6)

docs/en/features/ConfigurationFile.md
docs/features/ConfigurationFile.md
src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintFlags.java
src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplier.java
src/main/resources/com/github/_1c_syntax/bsl/languageserver/configuration/schema.json
src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java

📝 Walkthrough

Walkthrough

VariableTypeInlayHintSupplier suppresses type inlay hints when a variable name already contains the inferred type name, using a case-insensitive check. Documentation and a regression test cover the behavior.

Changes

Variable type hint suppression

Layer / File(s)	Summary
Suppress redundant variable type hints `src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplier.java`, `src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java`	The supplier consolidates early exits, checks variable names against inferred type names before creating hints, documents the behavior, and tests that matching names produce no hints.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states the main change: suppressing type inlay hints when the variable name already contains the type name.
Linked Issues check	✅ Passed	The implementation matches the issue by suppressing variable type inlay hints when the name already includes the inferred type name.
Out of Scope Changes check	✅ Passed	The changes stay within the inlay hint logic and its test coverage, with no unrelated edits introduced.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/issue-4247-0meqa7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nixel2007 · 2026-07-14T08:03:55Z

/buildJar

Generated by Claude Code

github-actions · 2026-07-14T08:05:46Z

✅ Собраны JAR-файлы для этого PR по команде /buildJar.

Артефакт: 8304260982

Файлы внутри:

bsl-language-server-claude-issue-4247-0meqa7-7150527-exec.jar

coderabbitai

🧹 Nitpick comments (1)

src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java (1)
122-124: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Add a test case for case-insensitive containment.

The test variables (Массив and МассивИсточник) exactly match the casing of the inferred type Массив. Consider adding a test case with different casing to explicitly guarantee the case-insensitive behavior mentioned in the PR summary.
💡 Proposed test case addition
       	Массив = Источник;
       	МассивИсточник = Источник;
+      	массивОстатков = Источник;
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java`
around lines 122 - 124, Add a test case in VariableTypeInlayHintSupplierTest
covering containment when the variable and inferred type use different casing.
Keep the existing exact-case assertions and verify that the case-insensitive
match still infers the expected Массив type.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java`:
- Around line 122-124: Add a test case in VariableTypeInlayHintSupplierTest
covering containment when the variable and inferred type use different casing.
Keep the existing exact-case assertions and verify that the case-insensitive
match still infers the expected Массив type.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3fa6664e-dcb6-42c8-b07c-0c3ba4c912a7

📥 Commits

Reviewing files that changed from the base of the PR and between 316ff75 and 7150527.

📒 Files selected for processing (2)

src/main/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplier.java
src/test/java/com/github/_1c_syntax/bsl/languageserver/inlayhints/VariableTypeInlayHintSupplierTest.java

… регистронезависимость Sonar (java:S1142) ругался на 6 return в toInlayHint — проверка диапазона слита с проверкой тривиальности выражения, поведение не меняется. Также в тест добавлен кейс с именем переменной в другом регистре («массивОстатков»), подтверждающий регистронезависимость подавления. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01SSt7bML8BDg8DGV9BRDdjo

…еменной Подавление подсказки выведенного типа, когда имя переменной уже содержит имя типа, теперь управляется вложенным флагом конфига inlayHint.parameters.variableType.showTypeWithTheSameName (по умолчанию false — подавлять). Полная аналогия с showParametersWithTheSameName у methodCall: пользователь может вернуть показ таких подсказок. Обновлены JSON-схема и документация настроек (ru/en), добавлен тест на включённый флаг. Co-Authored-By: Claude Opus 4.8 <[email protected]> Claude-Session: https://claude.ai/code/session_01SSt7bML8BDg8DGV9BRDdjo

sonarqubecloud · 2026-07-14T08:47:10Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-07-14T09:09:45Z

Test Results

3 636 files ± 0 3 636 suites ±0 1h 46m 59s ⏱️ + 7m 21s
3 595 tests + 2 3 577 ✅ + 2 18 💤 ±0 0 ❌ ±0
21 570 runs +12 21 458 ✅ +12 112 💤 ±0 0 ❌ ±0

Results for commit e6b22ba. ± Comparison against base commit 316ff75.

coderabbitai Bot reviewed Jul 14, 2026

View reviewed changes

claude added 2 commits July 14, 2026 08:10

nixel2007 merged commit 308c22e into develop Jul 15, 2026
36 of 37 checks passed

nixel2007 deleted the claude/issue-4247-0meqa7 branch July 15, 2026 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(inlayhints): не показывать тип переменной, если имя уже несёт имя типа#4267

fix(inlayhints): не показывать тип переменной, если имя уже несёт имя типа#4267
nixel2007 merged 3 commits into
developfrom
claude/issue-4247-0meqa7

nixel2007 commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading

Review limit reached

Walkthrough

Changes

Uh oh!

nixel2007 commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

sonarqubecloud Bot commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

nixel2007 commented Jul 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Описание

Связанные задачи

Чеклист

Общие

Дополнительно

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Changes

Uh oh!

nixel2007 commented Jul 14, 2026

Uh oh!

github-actions Bot commented Jul 14, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Jul 14, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Jul 14, 2026

Test Results

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nixel2007 commented Jul 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 14, 2026 •

edited

Loading