src/main/java/com/github/_1c_syntax/bsl/languageserver/infrastructure/ExecutorConfiguration.java (1)

160-188: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate workspace-resolution logic across factory methods.

createWorkspaceForkJoinPool (Lines 161-166) and createWorkspaceBoundedPool (Lines 173-178) repeat identical WorkspaceContextHolder.get()/null-check/getName() resolution logic. Extract a shared private helper (e.g. resolveWorkspaceContext()) returning the URI/name pair to avoid drift between the two implementations.

♻️ Suggested extraction

+  private record WorkspaceContext(URI uri, String name) {}
+
+  private static WorkspaceContext resolveWorkspaceContext(String errorMessage) {
+    var workspaceUri = WorkspaceContextHolder.get();
+    if (workspaceUri == null) {
+      throw new IllegalStateException(errorMessage);
+    }
+    var workspaceName = Optional.ofNullable(WorkspaceContextHolder.getName())
+      .orElse("default");
+    return new WorkspaceContext(workspaceUri, workspaceName);
+  }
+
   private static ExecutorService createWorkspaceForkJoinPool(String prefix) {
-    var workspaceUri = WorkspaceContextHolder.get();
-    if (workspaceUri == null) {
-      throw new IllegalStateException("Workspace context is not set when creating ForkJoinPool");
-    }
-    var workspaceName = Optional.ofNullable(WorkspaceContextHolder.getName())
-      .orElse("default");
-    var factory = new WorkspaceAwareFJWTFactory(workspaceUri, workspaceName, prefix);
+    var ctx = resolveWorkspaceContext("Workspace context is not set when creating ForkJoinPool");
+    var factory = new WorkspaceAwareFJWTFactory(ctx.uri(), ctx.name(), prefix);
     var pool = new ForkJoinPool(ForkJoinPool.getCommonPoolParallelism(), factory, null, true);
     return new ContextPropagatingExecutorService(pool);
   }

   private static ExecutorService createWorkspaceBoundedPool(String prefix) {
-    var workspaceUri = WorkspaceContextHolder.get();
-    if (workspaceUri == null) {
-      throw new IllegalStateException("Workspace context is not set when creating executor");
-    }
-    var workspaceName = Optional.ofNullable(WorkspaceContextHolder.getName())
-      .orElse("default");
+    var ctx = resolveWorkspaceContext("Workspace context is not set when creating executor");
     var parallelism = ForkJoinPool.getCommonPoolParallelism();
-    var factory = new NamedThreadFactory(prefix + workspaceName + "-");
+    var factory = new NamedThreadFactory(prefix + ctx.name() + "-");

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/github/_1c_syntax/bsl/languageserver/infrastructure/ExecutorConfiguration.java`
around lines 160 - 188, Extract the duplicated workspace URI and name resolution
from createWorkspaceForkJoinPool and createWorkspaceBoundedPool into a shared
private helper such as resolveWorkspaceContext(), returning both values and
preserving the existing null validation and “default” name fallback. Update both
factory methods to reuse that helper when constructing their thread factories.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes