src/test/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContextProviderTest.java (1)

149-193: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Tests assume clean shared-bean state without explicit setup.

testResolveUntitledDocumentRoutesToFirstWorkspace (line 167) doesn't reset state at the start and relies on no stray default context leaking from a previous test using the shared serverContextProvider singleton bean. JUnit 5 doesn't guarantee declaration-order execution by default, so if testRegisterDefaultWorkspace/testResolveUntitledDocumentRoutesToDefaultWorkspace run without their cleanup executing first (e.g., failed cleanup after an earlier assertion failure), this test could observe an unexpected default context. This is a pre-existing pattern in the file (other tests also rely on manual cleanup rather than isolated @BeforeEach setup), so it's not new to this PR, but the added tests increase the shared-state surface.

Consider adding a @BeforeEach that calls serverContextProvider.clear() for defensive isolation.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/context/ServerContextProviderTest.java`
around lines 149 - 193, The new untitled-document tests in
ServerContextProviderTest rely on shared singleton state and can be affected by
leftover workspaces or a default context from earlier tests. Add defensive test
isolation by clearing serverContextProvider before each test, ideally via a
`@BeforeEach` setup in ServerContextProviderTest, so resolveContextForDocument and
the related workspace tests always start from a clean state.

src/test/java/com/github/_1c_syntax/bsl/languageserver/lsp/BSLLanguageServerTest.java (1)

162-178: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Test bypasses the real workspace-folder wiring path; overlaps with ServerContextProviderTest.

This test calls serverContextProvider.addWorkspace(folder) directly rather than driving it through the actual workspace/didChangeWorkspaceFolders handler, so it exercises the same routing contract already covered by ServerContextProviderTest.testAddingWorkspaceAtRuntimePromotesPrimaryFromDefault without adding coverage for the language-server-level wiring (e.g., watcher registration for the newly added folder) that this test class is meant to verify.

Consider driving this scenario through the server's actual workspace-folder-change entry point if one exists, to get genuine end-to-end coverage rather than duplicating the provider-level unit test.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/lsp/BSLLanguageServerTest.java`
around lines 162 - 178, Use the language-server workspace-folder change path
instead of calling ServerContextProvider.addWorkspace directly in
addingWorkspaceFolderAfterEmptyInitializeRoutesUntitledToIt; route the scenario
through the server’s workspace/didChangeWorkspaceFolders handler (or equivalent
entry point) so this test verifies the actual wiring, including any
watcher/registration behavior, rather than duplicating ServerContextProviderTest
coverage.

src/test/java/com/github/_1c_syntax/bsl/languageserver/lsp/BSLLanguageServerTest.java (1)

128-141: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Strengthen the routing assertion to verify identity, not just presence.

The test only asserts resolveContextForDocument(...) isPresent(), which would also pass if the document happened to resolve to some other context. Given the upstream contract states the default context is created with configurationRoot == null, asserting the resolved context is exactly the default one would make this test more precise against regressions in promoteToPrimary/getPrimaryContext.

✅ Suggested stronger assertion

     assertThat(serverContextProvider.getAllContexts())
       .containsKey(ServerContextProvider.DEFAULT_WORKSPACE_URI);
-    assertThat(serverContextProvider.resolveContextForDocument(URI.create("untitled:Untitled-1")))
-      .isPresent();
+    assertThat(serverContextProvider.resolveContextForDocument(URI.create("untitled:Untitled-1")))
+      .hasValueSatisfying(ctx ->
+        assertThat(ctx).isSameAs(serverContextProvider.getAllContexts().get(ServerContextProvider.DEFAULT_WORKSPACE_URI)));

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/lsp/BSLLanguageServerTest.java`
around lines 128 - 141, The routing assertion in BSLLanguageServerTest is too
weak because it only checks that resolveContextForDocument(...) returns a value,
not that it resolves to the default context. Update the test around
initializeWithoutWorkspaceRegistersDefaultWorkspace to assert the resolved
ServerContext is exactly the one stored under
ServerContextProvider.DEFAULT_WORKSPACE_URI, so it verifies identity and guards
the promoteToPrimary/getPrimaryContext contract rather than just presence.