fix(sentry): не падать на null-версии сервера при инициализации Sentry#4141
Conversation
resolveEnvironment(version) бросал NullPointerException, когда serverInfo.getVersion() возвращает null — а это происходит при запуске без манифеста (из IDE/исходников). Если при этом задан sentry.dsn, инициализация Sentry падала на старте. getEnvironment теперь трактует null-версию как окружение feature; resolveEnvironment сохраняет не-null контракт. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
|
Warning Review limit reached
More reviews will be available in 22 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
1 participant
Проблема
SentryScopeConfigurer.resolveEnvironment(version)бросаетNullPointerExceptionнаversion.matches(...), когдаserverInfo.getVersion()возвращаетnull. Версия равнаnullпри запуске без манифеста (из IDE/исходников — вMETA-INF/MANIFEST.MFнетImplementation-Version). Если при этом заданsentry.dsn, лямбдаsentryOptionsConfigurationвызывается при инициализации Sentry SDK на старте контекста → падение.Решение
getEnvironment()трактуетnull-версию как окружениеfeature(как и любую неизвестную строку версии).resolveEnvironment(String)сохраняет не-null контракт — null обрабатывается в вызывающем методе.Тест
SentryScopeConfigurerOptionsTest(Mockito-юнит):sentryOptionsConfiguration().configure(options)приgetVersion()==nullне падает и выставляет environmentfeature. Сначала написан красный (воспроизводит NPE), затем фикс.🤖 Generated with Claude Code