src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/DiagnosticProviderTest.java (1)

242-245: ⚡ Quick win

Assert ordering between cache clear and client refresh.

This test verifies both actions happened, but not that clearDiagnostics() occurs before refreshDiagnostics(), which is the core behavior this PR protects.

Proposed test hardening

+import org.mockito.InOrder;
 ...
   void testServerContextPopulatedClearsCachedDiagnosticsForPullClient() {
@@
     // then
-    verify(openedA, times(1)).clearDiagnostics();
-    verify(openedB, times(1)).clearDiagnostics();
-    verify(languageClient, times(1)).refreshDiagnostics();
+    verify(openedA, times(1)).clearDiagnostics();
+    verify(openedB, times(1)).clearDiagnostics();
+    verify(languageClient, times(1)).refreshDiagnostics();
+
+    InOrder inOrder = org.mockito.Mockito.inOrder(openedA, openedB, languageClient);
+    inOrder.verify(openedA).clearDiagnostics();
+    inOrder.verify(openedB).clearDiagnostics();
+    inOrder.verify(languageClient).refreshDiagnostics();
   }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/DiagnosticProviderTest.java`
around lines 242 - 245, The test verifies that clearDiagnostics() and
refreshDiagnostics() are called but does not enforce that clearDiagnostics()
occurs before refreshDiagnostics(), which is the critical behavior being tested.
Replace the separate verify statements with Mockito's InOrder verifier to assert
the correct execution sequence: first clearDiagnostics() on openedA and openedB,
then refreshDiagnostics() on languageClient. This ensures the test validates the
ordering requirement, not just the fact that both methods are called.