src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/CompletionProviderTest.java (1)

1658-1687: 📐 Maintainability & Code Quality | 💤 Low value

Consider aligning test scope with its name.

The test name mentions AndKeyword, and the comment states the local method should rank above both global function and keyword. However, the test only verifies localMethod < globalFunction without asserting against a keyword. While the ranking is mathematically proven by bucket values (BUCKET_LOCAL=1 < BUCKET_GLOBAL=2 < BUCKET_KEYWORD=4), explicitly testing the keyword case would improve coverage and align the test with its name.

📝 Suggested enhancement

Add an assertion for keyword ranking:

     var items = completionProvider.getCompletion(documentContext, params).getItems();
     var localMethod = sortTextOf(items, "Сообщение");
     var globalFunction = sortTextOf(items, "Сообщить");
+    var keyword = sortTextOf(items, "Сообщение"); // or another keyword with prefix "Сооб" if available

     // then
     assertThat(localMethod)
       .as("sortText локального метода и глобальной функции должны быть проставлены")
       .isNotNull();
     assertThat(globalFunction).isNotNull();
+    assertThat(keyword).isNotNull();
     assertThat(localMethod)
       .as("локальный метод документа ранжируется выше глобальной функции")
       .isLessThan(globalFunction);
+    assertThat(localMethod)
+      .as("локальный метод документа ранжируется выше ключевого слова")
+      .isLessThan(keyword);

Alternatively, rename the test to noDotCompletionRanksLocalMethodAboveGlobalFunction to match the current scope.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/providers/CompletionProviderTest.java`
around lines 1658 - 1687, The test name and comment claim the local method
should rank above both a global function and a keyword, but the test only
asserts localMethod < globalFunction; update the test
noDotCompletionRanksLocalMethodAboveGlobalFunctionAndKeyword to also fetch the
keyword sortText with sortTextOf(items, "<keyword>") (choose a language keyword
that appears in the completion set at the test position) and add assertions that
the keyword sortText is not null and that localMethod isLessThan(keyword) to
align coverage with the test name.