src/test/java/com/github/_1c_syntax/bsl/languageserver/semantictokens/SymbolsSemanticTokensSupplierTest.java (1)

148-200: ⚡ Quick win

Add one test for combined Static + Async declaration modifiers.

Async-only and static-only are covered, but the declared behavior allows both modifiers together. Add a targeted assertion to lock this contract and prevent regressions in modifier composition.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/test/java/com/github/_1c_syntax/bsl/languageserver/semantictokens/SymbolsSemanticTokensSupplierTest.java`
around lines 148 - 200, Add a new unit test (e.g.,
testStaticAndAsyncModifiersOnDeclaration) that constructs a BSL snippet with
both Static and Async modifiers (for both a function and/or procedure variant),
call helper.getDecodedTokens(bsl, supplier), and assert via
helper.assertContainsTokens that the declared symbol (use ExpectedToken) is
emitted with Set.of(SemanticTokenModifiers.Static, SemanticTokenModifiers.Async)
and the correct SemanticTokenTypes.Function or SemanticTokenTypes.Method and the
expected identifier text; reference helper.getDecodedTokens, ExpectedToken,
SemanticTokenModifiers.Static, SemanticTokenModifiers.Async,
SemanticTokenTypes.Function/SemanticTokenTypes.Method and
helper.assertContainsTokens to locate relevant code paths.

src/main/java/com/github/_1c_syntax/bsl/languageserver/semantictokens/SymbolsSemanticTokensSupplier.java (1)

49-55: ⚖️ Poor tradeoff

Consider extracting duplicated modifier constants to a shared utility.

The four modifier array constants (NO_MODIFIERS, ASYNC_MODIFIERS, STATIC_MODIFIERS, STATIC_ASYNC_MODIFIERS) and the helper method logic are duplicated between SymbolsSemanticTokensSupplier and MethodCallSemanticTokensSupplier. Extracting them to SemanticTokensHelper or a new utility class would eliminate the duplication.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/main/java/com/github/_1c_syntax/bsl/languageserver/semantictokens/SymbolsSemanticTokensSupplier.java`
around lines 49 - 55, Extract the duplicated modifier constants and helper logic
into a new utility class (e.g., SemanticTokensHelper) and replace the arrays and
helper usages in both SymbolsSemanticTokensSupplier and
MethodCallSemanticTokensSupplier with references to the new class; specifically
move NO_MODIFIERS, ASYNC_MODIFIERS, STATIC_MODIFIERS, STATIC_ASYNC_MODIFIERS and
any helper method that builds or selects modifier arrays from
SymbolsSemanticTokensSupplier and MethodCallSemanticTokensSupplier into
SemanticTokensHelper, make them public/static, and update the callers in both
classes to use SemanticTokensHelper.NO_MODIFIERS,
SemanticTokensHelper.ASYNC_MODIFIERS, etc., ensuring imports and visibility are
adjusted accordingly.