Skip to content

Fix regex for pre-release environment detection#3622

Merged
nixel2007 merged 1 commit into
developfrom
nixel2007-patch-2
Nov 21, 2025
Merged

Fix regex for pre-release environment detection#3622
nixel2007 merged 1 commit into
developfrom
nixel2007-patch-2

Conversation

@nixel2007

@nixel2007 nixel2007 commented Nov 21, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Описание

Связанные задачи

Closes

Чеклист

Общие

  • Ветка PR обновлена из develop
  • Отладочные, закомментированные и прочие, не имеющие смысла участки кода удалены
  • Изменения покрыты тестами
  • Обязательные действия перед коммитом выполнены (запускал команду gradlew precommit)

Для диагностик

  • Описание диагностики заполнено для обоих языков (присутствуют файлы для обоих языков, для русского заполнено все подробно, перевод на английский можно опустить)

Дополнительно

Summary by CodeRabbit

  • Chores
    • Refined release version validation pattern to enforce stricter formatting requirements for consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Copilot AI review requested due to automatic review settings November 21, 2025 18:55
@coderabbitai

coderabbitai Bot commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

A regex pattern in the Sentry GitHub Actions workflow has been updated to require a dot after pre-release identifiers, changing from -r[ca][0-9]+ to -r[ca]\.[0-9]+ to enforce stricter version format matching.

Changes

Cohort / File(s) Summary
Sentry Workflow Regex Update
.github/workflows/sentry.yml		 Modified RELEASE_VERSION regex pattern to require a literal dot after pre-release identifiers (-rc or -ra), enforcing version formats like 1.2.3-rc.1 instead of 1.2.3-rc1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single regex pattern modification in a workflow configuration file
  • Change is localized and syntactically straightforward
  • No logic alterations or multi-file impacts

Poem

A dot must follow -rc or -ra,
Version strings now more pristine by far!
The regex stands guard with stricter grace,
Keeping pre-releases in their proper place.
🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the regex pattern for pre-release version detection by requiring a dot after -rc or -ra.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch nixel2007-patch-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Nov 21, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regex pattern bug in the Sentry workflow that prevented correct detection of pre-release versions. The pattern now correctly matches the project's versioning format (e.g., 0.27.0-rc.1) by adding a missing dot separator before the release candidate number.

Key Changes

  • Fixed regex pattern in .github/workflows/sentry.yml to match the actual pre-release version format used in the project (X.Y.Z-rc.N or X.Y.Z-ra.N with a dot before the number)

coderabbitai[bot]
coderabbitai Bot reviewed Nov 21, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab7e066 and 0caca37.

📒 Files selected for processing (1)
  • .github/workflows/sentry.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
  • GitHub Check: Analyse
  • GitHub Check: build
  • GitHub Check: build (25, windows-latest)
  • GitHub Check: build (25, macOS-latest)
  • GitHub Check: build (25, ubuntu-latest)
  • GitHub Check: build (21, ubuntu-latest)
  • GitHub Check: build (21, macOS-latest)
  • GitHub Check: build (21, windows-latest)
  • GitHub Check: build (17, macOS-latest)
  • GitHub Check: build (17, ubuntu-latest)
  • GitHub Check: build (17, windows-latest)
  • GitHub Check: Analyze the repo with CodeSee

Comment thread .github/workflows/sentry.yml
@sonarqubecloud

sonarqubecloud Bot commented Nov 21, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nixel2007
nixel2007 enabled auto-merge November 21, 2025 19:08
@nixel2007
nixel2007 merged commit ba5b892 into develop Nov 21, 2025
42 checks passed
@nixel2007
nixel2007 deleted the nixel2007-patch-2 branch November 21, 2025 19:10
@coderabbitai coderabbitai Bot mentioned this pull request Jun 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nixel2007