Skip to content

Conversation

@itagagaki
Copy link
Member

Before:

bandicam.2024-12-06.20-21-56-554.mp4

After:

bandicam.2024-12-06.20-23-53-201.mp4

Same for Launcher, Database, and Theme.

I didn't change the indentation of the original content. That would make the difference unnecessarily large.

@VShawn VShawn merged commit bf58a45 into 1Remote:main Dec 7, 2024
1 check passed
@VShawn
Copy link
Member

VShawn commented Dec 7, 2024

GJ, Do I need to add you to the dev team?

@itagagaki
Copy link
Member Author

GJ, Do I need to add you to the dev team?

Yeah, I feel I can do a bit more if you do :)

@itagagaki
Copy link
Member Author

@VShawn
I am writing to you here as there seems to be no other way of contacting you.
Miodrag Milić sent me a direct email telling me that my behavior is unacceptable and that I should behave normally and respectfully if I want to avoid having my access to the 1Remote repository blocked. This is arrogant. Can you please tell me why he/she has such authority?

@VShawn
Copy link
Member

VShawn commented Dec 12, 2024

Can you please tell me why he/she has such authority?

To prevent something from happening, I've downgraded permissions from owner to maintainer.

So, what happened 10 hours ago? I only saw notifications that the message was deleted, and I didn't see any unacceptable behavior.

@majkinetor Don't you say something? And this isn't the first time you've sent conflicts with other developers. see ticket # 103.

@VShawn
Copy link
Member

VShawn commented Dec 21, 2024

ScrollViewer bring a bug that the button is dead

PixPin_2024-12-21_11-25-46.mp4

VShawn added a commit that referenced this pull request Dec 21, 2024
chore: allow smaller main window size.
@itagagaki
Copy link
Member Author

itagagaki commented Dec 21, 2024

I'm in the process of fixing it.
I want the DB list to be scrollable, but I want the headers to be fixed, so it's a bit more of a change. So what is the intention with the following two lines in the list header? Is it safe to remove them?

<TextBlock Text=" (Readonly)" Visibility="{Binding IsWritable, Converter={StaticResource ConverterBool2VisibleInv}}"></TextBlock>
<Grid Width="20"></Grid>

By the way, once a MySQL is added, is it not possible to add more? The add menu is grayed out and disabled, is this expected behavior? If so, maybe I don't need to scroll through the DB list.

But since it works so well, it's possible to continue the work for the future.

@VShawn
Copy link
Member

VShawn commented Dec 21, 2024

1

I want the DB list to be scrollable, but I want the headers to be fixed, so it's a bit more of a change.

Then you don't need to change anything, it's working well now.

PixPin_2024-12-21_15-40-57.mp4

2

By the way, once a MySQL is added, is it not possible to add more?

Yes, currently I allow users to add at most two MySQL databases because I haven't tested if the software can work properly with many MySQL connections.

Removing these two lines will unseal 1Remote.

https://github.com/1Remote/1Remote/blob/main/Ui/View/Settings/DataSource/DataSourceViewModel.cs#L117

https://github.com/1Remote/1Remote/blob/main/Ui/View/Settings/DataSource/DataSourceViewModel.cs#L69

3

So what is the intention with the following two lines in the list header? Is it safe to remove them?

<TextBlock Text=" (Readonly)" Visibility="{Binding IsWritable, Converter={StaticResource ConverterBool2VisibleInv}}"></TextBlock>
<Grid Width="20"></Grid>

Nope see https://1remote.org/usage/team/team-sharing/#how

@itagagaki
Copy link
Member Author

Oh, Ok, Good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants