Uh, I don't remember why there was a recursive call in the exception; this code is quite old.

I guess the purpose:

when an error occurred during jumping from directory A to display directory B, thee code in the except block allows the UI to revert to displaying directory A. otherwise, due to the error in ls B, the UI would be blank.

Since I added a check CurrentPath != path before calling ShowFolder(CurrentPath, showIoMessage: false); I believed that infinite recursive calls would not occur.

Add a _lastFailedPath field to record the last failed, which can help avoid recursion.

            catch (Exception e)
            {
                IoMessageLevel = IoMessageLevelError;
                IoMessage = $"ls {CurrentPath}: " + e.Message;
                if (CurrentPath != path && CurrentPath != _lastFailedPath)
                {
                    _lastFailedPath = path;
                    ShowFolder(CurrentPath, showIoMessage: false);
                }
                return;
            }

Uh oh!

An incorrect password in FTP will cause an exception to be thrown forever #841

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions