Replies: 5 comments 10 replies
-
|
Hm... what happened with replies here... I got them on email... |
Beta Was this translation helpful? Give feedback.
-
|
@VShawn recommended: i suggest you can wait in the script file, e.g. in powershell: "C:\Program Files\OpenVPN\bin\openvpn-gui.exe" --command myconnection.ovpn # open vpn
do {
Write-Host "waiting..."
sleep 3
} until(Test-NetConnection $Env:PRM_HOST -Port $Env:PRM_PORT | ? { $_.TcpTestSucceeded } ) # loop until IP:port is respondingI did not test the script, you may need debug above scrip to make it works :) |
Beta Was this translation helpful? Give feedback.
-
|
Something like this is the way to go indeed, u would need to have timeout though, so it doesn't happen to wait forever in the background. |
Beta Was this translation helpful? Give feedback.
-
|
Great idea! I had to tweak your suggestion a little bit, but now it works. 😁😁😁 "C:\Program Files\OpenVPN\bin\openvpn-gui.exe" --command myconnection.ovpn # open vpn tunnel
$loop = 0
do {
$loop++
Write-Host "Checking VPN connection... ($loop)"
} until (Test-Port $Env:PRM_HOST $Env:PRM_PORT | ? { $_.PortOpened } ) # loop until IP:port is respondingFunction Test-Port is from A fast way to check TCP port in Powershell I had to use Test-Port instead of Test-NetConnection, because
|
Beta Was this translation helpful? Give feedback.
-
|
This looks happier: "$Env:ProgramFiles\OpenVPN\bin\openvpn-gui.exe" --command myconnection.ovpn
Write-Host "Checking VPN connection" -NoNewLine
$i = 0
while(1) {
Write-Host -NoNewLine ' .'
$portOpened = Test-Port $Env:PRM_HOST $Env:PRM_PORT | ? { $_.PortOpened }
if ($portOpened -or $i -gt 60) { break } else { Start-Sleep 1; $i++}
}
if ($i -gt 60) { Write-Error 'timeout' } |
Beta Was this translation helpful? Give feedback.
-
|
I agree that this is more readable. I'm using your ideas now in my script. And I removed the sleep command as Test-Port itself takes nearly one second while the connection is not yet available. Unfortunately PRemoteM ignores when a timeout happens. The RDP session is started nevertheless. I also tried Exit 1 instead of Write-Error 'timeout'. Same result. Does PRemoteM check if my "script before connect" was successful? |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately nope, PRemoteM will continue opening the session whatever script's exit code is. I didn't expect a scrip will give a return code when I design this feature. |
Beta Was this translation helpful? Give feedback.
-
|
It's easy to return an exit code from ps1/cmd/bat files. Use "Exit 1" in powershell or "exit /b 1" in batch files. 0 means success, everything else means failure. Having said this, it would make sense to implement checking the return value of the "before script" in PRemoteM at some rainy day in the future. Till then I can live with the current behavior. 😉 |
Beta Was this translation helpful? Give feedback.
-
|
yeap, it's available on latest version. #376 |
Beta Was this translation helpful? Give feedback.
-
|
I have a question. How do you solve the problem of VPN disconnection? For example, if you have two sessions that require a VPN connection and closing one will cause the VPN to disconnect, thereby causing the other connection to also be disconnected. |
Beta Was this translation helpful? Give feedback.
-
|
Script can increment on disk number of open connections and disconnect VPN only if there is no more running. Not sure what will happen if it is forcefully disconnected (i.e. internet problem), does the end script runs ? |
Beta Was this translation helpful? Give feedback.
-
|
Yes I run the script when the connection instance destruct, no matter if it is forcefully disconnected |
Beta Was this translation helpful? Give feedback.
-
|
So that is solution then, its trivial. |
Beta Was this translation helpful? Give feedback.
-
|
Other one would be to allow some IPC mechanism to ask running PRM for info about specific connections, but I recon that is more work for both you to develop and user of the script. It would also be probably OS specific while I would suggest to keep stuff cross platform as much as possible. |
Beta Was this translation helpful? Give feedback.
-
|
Fortunately I don't have to solve this problem. 😊 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
One of my windows servers is behind VPN. So I have to connect the VPN tunnel first, wait until it's connected, then run the RDP connection. I'm trying to automate this with PRemoteM 7.2.3 using OpenVPN 2.5.8.
Script before connect: "C:\Program Files\OpenVPN\bin\openvpn-gui.exe" --command myconnection.ovpn
Script after disconnected: "C:\Program Files\OpenVPN\bin\openvpn-gui.exe" --command disconnect myconnection.ovpn
Both scripts work. However they return immediately. So PRemoteM launches the RDP connection immediately. The result is that the RDP connection doesn't connect.
Any ideas how to fix this?
Markus
Beta Was this translation helpful? Give feedback.
All reactions