Make desktop shortcut filename valid (#844)

itagagaki · web-flow · commit 0761d8c98ee8 · 2025-01-28T12:50:19.000+08:00
Replace all unavailable characters with _
diff --git a/Ui/Service/AppStartupHelper.cs b/Ui/Service/AppStartupHelper.cs
@@ -260,6 +260,7 @@ private static void ProcessArg(HashSet<string> args)
         public static string? MakeIcon(string name, Bitmap? bitmap)
         {
             if (bitmap == null) return null;
+            MakeFilenameValid(ref name);
             string? iconPath = null;
             iconPath = System.IO.Path.Combine(AppPathHelper.Instance.LocalityIconDirPath, $"{name}.ico");
             Executor.TryCatch(() =>
@@ -276,6 +277,19 @@ private static void ProcessArg(HashSet<string> args)
             return null;
         }
 
+        private static void MakeFilenameValid(ref string name)
+        {
+            name = name.Replace('\\', '_')
+                       .Replace('/', '_')
+                       .Replace(':', '_')
+                       .Replace('*', '_')
+                       .Replace('?', '_')
+                       .Replace('"', '_')
+                       .Replace('<', '_')
+                       .Replace('>', '_')
+                       .Replace('|', '_');
+        }
+
         public static void InstallDesktopShortcutByTag(string name, string tag, string? iconLocation = null)
         {
             if (name.StartsWith("Tag=") == false)
@@ -290,6 +304,7 @@ public static void InstallDesktopShortcutByUlid(string name, IEnumerable<string>
 
         public static void InstallDesktopShortcut(bool isInstall, string name = Assert.APP_DISPLAY_NAME, string parameter = "", string? iconLocation = null)
         {
+            MakeFilenameValid(ref name);
             try
             {
                 var desktopPath = Environment.GetFolderPath(Environment.SpecialFolder.DesktopDirectory);
