Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

Comments

Initial cli-installer implementation#1

Merged
volodymyrZotov merged 12 commits intomainfrom
vzt/v1
Aug 13, 2025
Merged

Initial cli-installer implementation#1
volodymyrZotov merged 12 commits intomainfrom
vzt/v1

Conversation

@volodymyrZotov
Copy link
Contributor

@volodymyrZotov volodymyrZotov commented Aug 4, 2025

This is initial implementation of op-cli-installer.

Typescript code from install-cli-action is copied to this repo as it is, without any changes. Only exported function installCliOnGithubActionRunner doesn't handle errors to allows end users to handle errors in their way.
The code is placed inside github-action module, to identify that this code is only applicable for github actions. This also allows to extend this repo in the future if we would need to install CLI in other scenarios.

Exported installCliOnGithubActionRunner - the main function that installs the CLI on github runners. Along with ReleaseChannel and VersionResolver - they are not used as exported pieces. But as now this repo is a library, I think this is beneficial to export those entries as well.

For now we do not build and publish an NPM package with this code. We'll install it as dependency in install-cli-action and load-secrets-action directly from github.

Implementation steps

  1. Init project and setup: Jest, lint-staged, eslint, prettier, husky
  2. Add github action job that lints, formats, tests and type checks the code. Also another job checks signed commits.
  3. Copied code from install-cli-action

How to test

  1. Unit tests are passing in pipeline
  2. Code from this repo is used as dependency in install-cli-action PR, that has integration tests. As you can see pipeline in this PR is passing, confirming that action works well and can install CLI on different runners (linux, windows and macos) using this repo as dependency.

Copy link
Member

@edif2008 edif2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: ✅

Things look straight forward and on point. Basically a new TS project with the changes from install-cli-action

Functional review: ➖

Haven't done any, but since it's used in both install-cli-action and load-secrets-action and it works in both, I'm confident in these changes.

@volodymyrZotov volodymyrZotov merged commit 48d060f into main Aug 13, 2025
2 checks passed
@volodymyrZotov volodymyrZotov deleted the vzt/v1 branch August 13, 2025 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants