Set export-env input to false by default#114
Merged
volodymyrZotov merged 4 commits intomainfrom Aug 14, 2025
Merged
Conversation
edif2008
approved these changes
Aug 14, 2025
Member
edif2008
left a comment
edif2008
left a comment
There was a problem hiding this comment.
Thank you for making this change. This will default to the safer way of providing secrets for following steps.
Approved with a couple of nits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we anyway plan to release v3, I think this is a good opportunity to introduce this breaking change.
So, in
v3of the action theexport-envinput will defaults tofalse.This will help to mitigate the next security concern. As exporting secret as env variable in the job will make it available for all future steps including 3d party actions. If some malicious 3d party action is used it can get an access to the secret from env var.
Though, the risk is low, the safer way for the action would be to defaults to
falseand let the users explicitly setexport-envinput, if they want to export secrets as env variables.This PR also updates readme to show reccomended example of using secrets as step outputs as well as exporting secrets as env vars.
Resolves #79