Use op cli installer to enable Windows support#109
Merged
volodymyrZotov merged 10 commits intomainfrom Aug 13, 2025
Merged
Conversation
volodymyrZotov
force-pushed
the
vzt/use-op-cli-installer
branch
from
05e2fe3 to
96de656
Compare
edif2008
reviewed
Aug 8, 2025
Member
edif2008
left a comment
edif2008
left a comment
There was a problem hiding this comment.
Code review: ✅
Things look much nicer and easier to maintain long term. Thank you for this effort.
I appreciate you switching the configuration piece of the action into Node as well to keep it all the same.
Functional review: ✅
This is tricky to test locally with act, but since all the pipelines work (including the Windows ones), I'm confident on these changes.
Other notes
Since this is quite a large change, do you consider it's worth making a v3? Or are we confident that it has little to no breaking changes so that we can still use v2?
This should be properly tested in op-cli-installer package. Current test will confirm that secrets are loaded correctly.
volodymyrZotov
force-pushed
the
vzt/use-op-cli-installer
branch
from
d925677 to
40b6ef7
Compare
edif2008
approved these changes
Aug 13, 2025
…ets-action. Remove type: "module" from package.json so ncc builds CommonJS configure action which is required
volodymyrZotov
force-pushed
the
vzt/use-op-cli-installer
branch
from
c92c146 to
596d800
Compare
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started to use op-cli-installer package as dependency, to install CLI. This enables Windows support for
load-secrets-action.Main changes
installCliOnGithubActionRunnerfunction from op-cli-installer instead ofinstall-cli.shscript.configureaction is refactored and now is written in pure JS, which helps wot enable Windows support.confitureaction set env vars properly and verifies installed CLI version.Resolves #46