Merged
Conversation
…`op-cli-installer` now
If failed, it should not push had users have to fix formatting and eslint errors by himself and re-try to commit/push
edif2008
approved these changes
Aug 8, 2025
Member
edif2008
left a comment
edif2008
left a comment
There was a problem hiding this comment.
Code review: ✅
Straight forward and on point. It's larger due to the code being moved in the op-cli-installer package, which is reasonable. The other changes are also clear.
Functional review: ✅
The pipeline passes and I've also tested locally a simulated version of the workflow using act and it works as expected.
Contributor
Author
|
Will merge as soon as 1Password/op-cli-installer#1 is merged, to make sure we use latest commit hash here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started to use "op-cli-installer" package and removes all the related source code from this repo.
Also it makes change in
lint-stagedconfiguration, so now lint-staged checks code formatting and lints it. If there are any errors it fails to commit/push and user should fix formatting and lint errors and try again.The unit tests are also removed from
lint-stagedshould be run as a part of ci/cd job. For now we removedRun jest testsfrom CI/CD as there are no tests in this repo, but all the underlying functionality is tested in op-cli-installer package.